Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unmaintained modulefiles #2280

Closed
DusanJovic-NOAA opened this issue May 14, 2024 · 5 comments
Closed

Remove unmaintained modulefiles #2280

DusanJovic-NOAA opened this issue May 14, 2024 · 5 comments

Comments

@DusanJovic-NOAA
Copy link
Collaborator

The following 3 modulefiles seem to be unmaintained for quite some time:

  • ufs_expanse.intel last update 3 years ago
  • ufs_odin last update 3 years ago
  • ufs_stampede.lua last update last year

They should be removed from the repository. Or updated to load the current version of the libraries model depends on, if anyone is still using them.

@gspetro-NOAA
Copy link
Collaborator

@DusanJovic-NOAA I am working on a PR to remove the modulefiles but wanted to be clear on what you had in mind. Do you want me also to remove logic from the RT scripts and other portions of the code that references the machines in question? Or should we leave that logic in place in case a user wants to provide their own modulefile?

@DusanJovic-NOAA
Copy link
Collaborator Author

@DusanJovic-NOAA I am working on a PR to remove the modulefiles but wanted to be clear on what you had in mind. Do you want me also to remove logic from the RT scripts and other portions of the code that references the machines in question? Or should we leave that logic in place in case a user wants to provide their own modulefile?

@gspetro-NOAA Please remove all references to removed modulefiles from all scripts. That code is also unmaintained/unused and probably out-of-date. Have you confirmed those three machines are not used by anybody.

@gspetro-NOAA
Copy link
Collaborator

@DusanJovic-NOAA Will do! We were going to ask @ywangwof about Odin, but I believe that system was removed from SRW Tier-2 systems a couple years ago. Do you have recommendations for whom we would talk to about the others? Seems that Expanse points to @climbfuji 's HPC-Stack installation and Stampede points to @Hang-Lei-NOAA 's HPC-Stack installation. If we keep any of these modulefiles, it seems like we'd want to update them to spack-stack at a minimum, but without access, that's not something EPIC can do.

@gspetro-NOAA
Copy link
Collaborator

I heard back from Dom and Yunheng, and they agreed with removing Expanse & Odin, respectively. I have not yet heard back from Hang Lei on Stampede. However, according to this article, Stampede2 (used in detect_machine.sh) reached end-of-life in Dec. 2023, so it seems reasonable to remove Stampede-related logic, which is all Stampede2-based.

@gspetro-NOAA
Copy link
Collaborator

Addressed in PR #2570, merged via PR #2569.

@github-project-automation github-project-automation bot moved this from In Progress to Done in ufs-community User Support Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
2 participants