Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove display:none for suggetion5 #39

Open
ctgraham opened this issue Dec 11, 2024 · 5 comments
Open

Remove display:none for suggetion5 #39

ctgraham opened this issue Dec 11, 2024 · 5 comments
Assignees

Comments

@ctgraham
Copy link
Member

This CSS rule needs to be removed to support modifications to nui.noresults.suggestions5.

/* Remove the last LI in the UL saying there are no results for your search */
prm-no-search-result md-card md-card-content ul>li:nth-child(5) {
display:none;
}

@alex-wreschnig
Copy link
Member

I've uploaded this change to our current test view in the Sandbox, available here:
https://pitt-psb.primo.exlibrisgroup.com/discovery/search?query=any,contains,alsdjfh;lkjh;lkajshdf;kljhalskdjhfka;ljshd&tab=Everything&search_scope=MyInst_and_CI&vid=01PITT_INST:ULS_1_12&lang=en&offset=0

I think I've gotten the right test case but I'm open to corrections!

@ctgraham
Copy link
Member Author

Looks right to me. Production push will be related to https://osticket.library.pitt.edu/scp/tickets.php?id=21796

@alex-wreschnig
Copy link
Member

I'll refresh my memory on how we handle deployments, then, and put this into production.

This feels like a pretty minor change, so do we need to notify anyone besides the Primo Admins group?

@alex-wreschnig
Copy link
Member

And should I be updating the change management spreadsheet or are we delegating that to someone else?

@ctgraham
Copy link
Member Author

This is tied to change record 271 in the main sheet; but that row represents both this change and the config change in Alma.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants