Skip to content

Commit

Permalink
fix(tests): update SendEvent mock to use EXPECT instead of On in serv…
Browse files Browse the repository at this point in the history
…ice tests

Signed-off-by: Sammy Oina <[email protected]>
  • Loading branch information
SammyOina committed Jan 17, 2025
1 parent 1c6de68 commit 14f4841
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 9 deletions.
13 changes: 5 additions & 8 deletions agent/service_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,7 @@ func TestAlgo(t *testing.T) {
)

events := new(mocks.Service)
evCall := events.On("SendEvent", mock.Anything, mock.Anything, mock.Anything, mock.Anything).Return(nil)
defer evCall.Unset()
events.EXPECT().SendEvent(mock.Anything, mock.Anything, mock.Anything, mock.Anything).Return()

ctx, cancel := context.WithCancel(ctx)
defer cancel()
Expand Down Expand Up @@ -207,8 +206,7 @@ func TestData(t *testing.T) {
)

events := new(mocks.Service)
evCall := events.On("SendEvent", mock.Anything, mock.Anything, mock.Anything, mock.Anything).Return(nil)
defer evCall.Unset()
events.EXPECT().SendEvent(mock.Anything, mock.Anything, mock.Anything, mock.Anything).Return()

if tc.err != ErrUndeclaredDataset {
ctx = IndexToContext(ctx, 0)
Expand Down Expand Up @@ -285,8 +283,8 @@ func TestResult(t *testing.T) {

for _, tc := range cases {
events := new(mocks.Service)
evCall := events.On("SendEvent", mock.Anything, mock.Anything, mock.Anything, mock.Anything).Return(nil)
defer evCall.Unset()
events.EXPECT().SendEvent(mock.Anything, mock.Anything, mock.Anything, mock.Anything).Return()

t.Run(tc.name, func(t *testing.T) {
ctx := metadata.NewIncomingContext(context.Background(),
metadata.Pairs(algorithm.AlgoTypeKey, "python", python.PyRuntimeKey, python.PyRuntime),
Expand Down Expand Up @@ -349,8 +347,7 @@ func TestAttestation(t *testing.T) {
for _, tc := range cases {
t.Run(tc.name, func(t *testing.T) {
events := new(mocks.Service)
evCall := events.On("SendEvent", mock.Anything, mock.Anything, mock.Anything, mock.Anything).Return(nil)
defer evCall.Unset()
events.EXPECT().SendEvent(mock.Anything, mock.Anything, mock.Anything, mock.Anything).Return()

ctx := metadata.NewIncomingContext(context.Background(),
metadata.Pairs(algorithm.AlgoTypeKey, "python", python.PyRuntimeKey, python.PyRuntime),
Expand Down
2 changes: 1 addition & 1 deletion mockery.yml
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ packages:
dir: "{{.InterfaceDir}}/mocks"
filename: "sdk.go"
mockname: "{{.InterfaceName}}"
github.com/ultravioletrs/cocos/agent/cvm/server:
github.com/ultravioletrs/cocos/agent/cvms/server:
interfaces:
AgentServerProvider:
config:
Expand Down

0 comments on commit 14f4841

Please sign in to comment.