NOISSUE - Handle larger manifests exceeding the default grpc limit #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SammyOina
requested changes
Jun 27, 2024
manager/api/grpc/server.go
Outdated
| return err | ||
| } | ||
| for start := 0; start < len(data); start += chunkSize { |
There was a problem hiding this comment.
use a byte buffer to read chunks, see cocos sdk for an example
smithjilks
force-pushed
the
cocos-249
branch
2 times, most recently
from
2c6374f to
46e469e
Compare
SammyOina
requested changes
Jul 8, 2024
manager/manager_test.go
Outdated
| ) | ||
|
|
||
| func init() { | ||
| logger, err := mglog.New(os.Stdout, "debug") |
There was a problem hiding this comment.
just use mock logger for tests
manager/manager_test.go
Outdated
| func (s *svc) Run(ipAddress string, runReqChan chan *manager.ServerStreamMessage, authInfo credentials.AuthInfo) { | ||
| privKey, err := rsa.GenerateKey(rand.Reader, keyBitSize) | ||
| if err != nil { | ||
| s.logger.Error(fmt.Sprintf("Error generating public key: %v", err)) |
There was a problem hiding this comment.
fail test rather than logging errors, pass testting.T on svc struct
manager/manager_test.go
Outdated
| attestedTLS = false | ||
| ) | ||
|
|
||
| func init() { |
There was a problem hiding this comment.
Use testmain for setup rather than init for test setup
SammyOina
requested changes
Jul 8, 2024
There was a problem hiding this comment.
add test cases for different senarios
|
@smithjilks please resolve these remarks |
smithjilks
force-pushed
the
cocos-249
branch
5 times, most recently
from
93e1e2b to
546e2b4
Compare
SammyOina
requested changes
Jul 31, 2024
manager/api/grpc/client.go
Outdated
| @@ -32,21 +37,37 @@ func (client ManagerClient) Process(ctx context.Context, cancel context.CancelFu | |||
| eg, ctx := errgroup.WithContext(ctx) | |||
|
|
|||
| eg.Go(func() error { | |||
| var data bytes.Buffer | |||
Signed-off-by: Jilks Smith <[email protected]>
Signed-off-by: Jilks Smith <[email protected]>
SammyOina
requested changes
Aug 2, 2024
manager/api/grpc/client.go
Outdated
| if len(mes.RunReqChunks.Data) == 0 { | ||
| var runReq pkgmanager.ComputationRunReq | ||
| if err = proto.Unmarshal(runReqBuffer.Bytes(), &runReq); err != nil { | ||
| return errCorruptedManifest |
SammyOina
requested changes
Aug 2, 2024
manager/api/grpc/client.go
Outdated
| } | ||
| runReqBuffer.Write(mes.RunReqChunks.Data) |
SammyOina
requested changes
Aug 5, 2024
manager/api/grpc/server.go
Outdated
Comment on lines
68
to
106
| case *manager.ServerStreamMessage_RunReq: | ||
| data, err := proto.Marshal(msg.RunReq) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| dataBuffer := bytes.NewBuffer(data) | ||
| buf := make([]byte, bufferSize) | ||
| for { | ||
| n, err := dataBuffer.Read(buf) | ||
| chunk := &manager.ServerStreamMessage{ | ||
| Message: &manager.ServerStreamMessage_RunReqChunks{ | ||
| RunReqChunks: &manager.RunReqChunks{ | ||
| Data: buf[:n], | ||
| }, | ||
| }, | ||
| } | ||
|
|
||
| if err := stream.Send(chunk); err != nil { | ||
| return err | ||
| } | ||
|
|
||
| if err == io.EOF { | ||
| break | ||
| } | ||
| } | ||
|
|
||
| case *manager.ServerStreamMessage_TerminateReq: | ||
| terminate := &manager.ServerStreamMessage{ | ||
| Message: &manager.ServerStreamMessage_TerminateReq{ | ||
| TerminateReq: msg.TerminateReq, | ||
| }, | ||
| } | ||
| if err := stream.Send(terminate); err != nil { | ||
| return err | ||
| } | ||
|
|
||
| default: | ||
| return ErrUnexpectedMsg | ||
| } |
There was a problem hiding this comment.
handle all message types as in main
SammyOina
requested changes
Aug 6, 2024
manager/api/grpc/server.go
Outdated
Comment on lines
94
to
124
| case *manager.ServerStreamMessage_TerminateReq: | ||
| terminate := &manager.ServerStreamMessage{ | ||
| Message: &manager.ServerStreamMessage_TerminateReq{ | ||
| TerminateReq: msg.TerminateReq, | ||
| }, | ||
| } | ||
| if err := stream.Send(terminate); err != nil { | ||
| return err | ||
| } | ||
|
|
||
| case *manager.ServerStreamMessage_StopComputation: | ||
| stopComp := &manager.ServerStreamMessage{ | ||
| Message: &manager.ServerStreamMessage_StopComputation{ | ||
| StopComputation: msg.StopComputation, | ||
| }, | ||
| } | ||
| if err := stream.Send(stopComp); err != nil { | ||
| return err | ||
| } | ||
|
|
||
| case *manager.ServerStreamMessage_BackendInfoReq: | ||
| backendInfo := &manager.ServerStreamMessage{ | ||
| Message: &manager.ServerStreamMessage_BackendInfoReq{ | ||
| BackendInfoReq: msg.BackendInfoReq, | ||
| }, | ||
| } | ||
| if err := stream.Send(backendInfo); err != nil { | ||
| return err | ||
| } | ||
| default: | ||
| return ErrUnexpectedMsg |
There was a problem hiding this comment.
use the fault case to send all other messages, and no need to create new variables.
SammyOina
requested changes
Aug 6, 2024
manager/api/grpc/client.go
Outdated
| if err := client.stream.Send(&pkgmanager.ClientStreamMessage{Message: runRes}); err != nil { | ||
| return err | ||
| } | ||
| return nil |
There was a problem hiding this comment.
Suggested change
| return nil |
is a goroutine on client and should not return here
SammyOina
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature to allow streaming manifests larger than the default grpc limit
What does this do?
Adds ability to stream large computation manifests in chunks.
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
No, I have not included tests.
Did you document any new/modified feature?
Notes