Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Enable WASM Support and FileSystem Support #189

Merged
merged 19 commits into from
Aug 6, 2024

Conversation

rodneyosodo
Copy link
Contributor

What type of PR is this?

This PR is a feature because it adds support of running wasm algorithms and also adds support for using filesystem to store results for the different algorithms

What does this do?

This pull request introduces support for WebAssembly (Wasm) as a new algorithm type, refactors algorithm creation functions, enhances error handling and logging, updates the CLI for result file path specification, changes the agent build configuration, and updates the Protobuf compiler version in the CI workflow.

  • New Features

    • Introduced support for WebAssembly (Wasm) algorithms, expanding the algorithm capabilities.
    • Added a feature to zip the results directory, enhancing result management.
  • Improvements

    • Enhanced error handling for algorithm execution and result processing.
    • Refactored the algorithm creation functions to use a more descriptive name NewAlgorithm.
  • Configuration Changes

    • I updated the configuration for the WasmEdge package and related build options in the Linux setup.
  • CI:

    • Updated the Protobuf compiler version in the CI workflow.

Which issue(s) does this PR fix/relate to?

No issue

Have you included tests for your changes?

Tested manually for binary and wasm targets for https://github.com/ultravioletrs/ai/tree/main/burn-algorithms

Did you document any new/modified feature?

To be updated on https://github.com/ultravioletrs/cocos-docs

Notes

@rodneyosodo rodneyosodo force-pushed the filesystem branch 2 times, most recently from e5a2577 to 80738c2 Compare July 31, 2024 11:18
@rodneyosodo rodneyosodo force-pushed the filesystem branch 2 times, most recently from 48feecd to 4b76d5c Compare July 31, 2024 12:47
const ResultsDir = "results"

// ZipDirectory zips a directory and returns the zipped bytes.
func ZipDirectory() ([]byte, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add test

@SammyOina
Copy link
Contributor

also add a wasm example for the lin reg example, in the test directory

@SammyOina
Copy link
Contributor

datasets should be stored in datatsets directory and results in results dir

@SammyOina
Copy link
Contributor

datasets should be stored in datatsets directory and results in results dir

also modify the lin_reg example here

@rodneyosodo rodneyosodo force-pushed the filesystem branch 3 times, most recently from 7da4182 to 13e4105 Compare August 2, 2024 11:06
Signed-off-by: Rodney Osodo <[email protected]>
@rodneyosodo rodneyosodo marked this pull request as draft August 2, 2024 12:26
Document steps on running the 2 python exampls and ensure they are running on eos

Signed-off-by: Rodney Osodo <[email protected]>
@rodneyosodo rodneyosodo marked this pull request as ready for review August 2, 2024 12:29
@drasko drasko merged commit afc306a into ultravioletrs:main Aug 6, 2024
2 checks passed
@rodneyosodo rodneyosodo deleted the filesystem branch August 7, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants