-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NOISSUE - Enable WASM Support and FileSystem Support #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rodney Osodo <[email protected]>
Move from unix socket for results storage to filesystem
Signed-off-by: Rodney Osodo <[email protected]>
Wasmedge enables easier directory mapping to get results Signed-off-by: Rodney Osodo <[email protected]>
Create a new function to zip the results directory and send it back to the user
Fix the directory mapping for wasm runtime arguments Signed-off-by: Rodney Osodo <[email protected]>
e5a2577
to
80738c2
Compare
Signed-off-by: Rodney Osodo <[email protected]>
48feecd
to
4b76d5c
Compare
SammyOina
requested changes
Jul 31, 2024
const ResultsDir = "results" | ||
|
||
// ZipDirectory zips a directory and returns the zipped bytes. | ||
func ZipDirectory() ([]byte, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add test
also add a wasm example for the lin reg example, in the test directory |
datasets should be stored in |
also modify the lin_reg example here |
7da4182
to
13e4105
Compare
Signed-off-by: Rodney Osodo <[email protected]>
Document steps on running the 2 python exampls and ensure they are running on eos Signed-off-by: Rodney Osodo <[email protected]>
SammyOina
requested changes
Aug 2, 2024
SammyOina
requested changes
Aug 4, 2024
Signed-off-by: Rodney Osodo <[email protected]>
This was referenced Aug 5, 2024
SammyOina
approved these changes
Aug 6, 2024
SammyOina
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This PR is a feature because it adds support of running wasm algorithms and also adds support for using filesystem to store results for the different algorithms
What does this do?
This pull request introduces support for WebAssembly (Wasm) as a new algorithm type, refactors algorithm creation functions, enhances error handling and logging, updates the CLI for result file path specification, changes the agent build configuration, and updates the Protobuf compiler version in the CI workflow.
New Features
Improvements
NewAlgorithm
.Configuration Changes
CI:
Which issue(s) does this PR fix/relate to?
No issue
Have you included tests for your changes?
Tested manually for binary and wasm targets for https://github.com/ultravioletrs/ai/tree/main/burn-algorithms
Did you document any new/modified feature?
To be updated on https://github.com/ultravioletrs/cocos-docs
Notes