Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COCOS-159 - Improve test coverage to 65% #310

Merged
merged 8 commits into from
Nov 19, 2024

Conversation

SammyOina
Copy link
Contributor

@SammyOina SammyOina commented Nov 12, 2024

What type of PR is this?

What does this do?

  • New Features

    • Introduced comprehensive test cases for error handling in file operations and state machine functionalities.
    • Added new test cases for ATLS listener and connection functionalities, enhancing coverage for various scenarios.
  • Bug Fixes

    • Improved error handling checks for nonexistent files in copy and checksum operations.
  • Documentation

    • Updated the structure and naming conventions in the backend_info.json file for clarity and consistency.
  • Tests

    • Enhanced test coverage with table-driven tests for various components, improving organization and readability.

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Did you document any new/modified feature?

Notes

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.42%. Comparing base (d5941ed) to head (acd0092).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #310      +/-   ##
==========================================
+ Coverage   62.36%   65.42%   +3.06%     
==========================================
  Files          54       53       -1     
  Lines        4320     4318       -2     
==========================================
+ Hits         2694     2825     +131     
+ Misses       1347     1218     -129     
+ Partials      279      275       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@SammyOina SammyOina marked this pull request as ready for review November 15, 2024 12:20
@SammyOina SammyOina changed the title few atls tests COCOS-159 - Improve test coverage to 65% Nov 15, 2024
Signed-off-by: Sammy Oina <[email protected]>
Signed-off-by: Sammy Oina <[email protected]>
Signed-off-by: Sammy Oina <[email protected]>
Signed-off-by: Sammy Oina <[email protected]>
Signed-off-by: Sammy Oina <[email protected]>
Signed-off-by: Sammy Oina <[email protected]>
@dborovcanin dborovcanin merged commit 5a22ac2 into ultravioletrs:main Nov 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Improve test coverage to exceed 65%
2 participants