-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
COCOS-344 - New agent structure #350
Conversation
Signed-off-by: Sammy Oina <[email protected]>
Signed-off-by: Sammy Oina <[email protected]>
Signed-off-by: Sammy Oina <[email protected]>
Signed-off-by: Sammy Oina <[email protected]>
Signed-off-by: Sammy Oina <[email protected]>
Signed-off-by: Sammy Oina <[email protected]>
Signed-off-by: Sammy Oina <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #350 +/- ##
==========================================
- Coverage 66.31% 65.41% -0.91%
==========================================
Files 53 57 +4
Lines 4391 4756 +365
==========================================
+ Hits 2912 3111 +199
- Misses 1207 1360 +153
- Partials 272 285 +13 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Sammy Oina <[email protected]>
Signed-off-by: Sammy Oina <[email protected]>
Signed-off-by: Sammy Oina <[email protected]>
Signed-off-by: Sammy Oina <[email protected]>
Signed-off-by: Sammy Oina <[email protected]>
} | ||
} | ||
|
||
type runRequestManager struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to avoid implementing this chunk manager (proto/grpc lib or 3rd-party lib)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
proto/grpc does not support it, I have not found a third party lib at the moment, I just looked at the simple implementation for out use case
…Client to CVMSClient Signed-off-by: Sammy Oina <[email protected]>
Signed-off-by: Sammy Oina <[email protected]>
Signed-off-by: Sammy Oina <[email protected]>
… tests Signed-off-by: Sammy Oina <[email protected]>
…ice tests Signed-off-by: Sammy Oina <[email protected]>
What type of PR is this?
What does this do?
New Features
Improvements
Breaking Changes
AgentConfig
from computation configurationsBug Fixes
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Did you document any new/modified feature?
Notes