COCOS-369 - Enable compiling gRPC clients without cGo #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #372 +/- ##
==========================================
- Coverage 59.57% 59.43% -0.15%
==========================================
Files 54 55 +1
Lines 4574 4573 -1
==========================================
- Hits 2725 2718 -7
- Misses 1564 1569 +5
- Partials 285 286 +1 ☔ View full report in Codecov by Sentry. |
|
Please resolve conflicts. |
SammyOina
changed the title
Signed-off-by: Sammy Oina <[email protected]>
Signed-off-by: Sammy Oina <[email protected]>
… pborman/uuid v1.2.1 Signed-off-by: Sammy Oina <[email protected]>
…ls functionality, and update related configurations Signed-off-by: Sammy Oina <[email protected]>
…tional methods Signed-off-by: Sammy Oina <[email protected]>
Signed-off-by: Sammy Oina <[email protected]>
dborovcanin
reviewed
Feb 13, 2025
| @@ -239,52 +215,3 @@ func ReadAttestationPolicy(manifestPath string, attestationConfiguration *check. | |||
|
|
|||
| return ErrAttestationPolicyMissing | |||
| } | |||
|
|
|||
| func CustomDialer(ctx context.Context, addr string) (net.Conn, error) { | |||
There was a problem hiding this comment.
Is this not needed anymore, i.e. it was not necessary in the first place?
There was a problem hiding this comment.
we need the custom dialer since we add tls extensions and standard go library does not allow for this
| // Copyright (c) Ultraviolet | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| //go:build !cgo |
dborovcanin
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this do?
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Did you document any new/modified feature?
Notes