Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COCOS-364 - Make agent more resilient to gRPC disconnection on cvms cloud server #375

Merged
merged 10 commits into from
Feb 16, 2025

Conversation

SammyOina
Copy link
Contributor

@SammyOina SammyOina commented Feb 13, 2025

What type of PR is this?

What does this do?

  • New Features
    • Enhanced state tracking with improved logging, metrics, and state exchange.
    • Added robust reconnection and pending message handling for improved client reliability.
  • Refactor
    • Streamlined server startup to run asynchronously.
    • Updated client initialization and testing setups.
  • Chores
    • Updated dependency versions and configuration settings for enhanced compatibility.

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Did you document any new/modified feature?

Notes

@SammyOina SammyOina changed the title Cocos 364 COCOS-364 - Make agent more resilient to gRPC disconnection on cvms cloud server Feb 13, 2025
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 43.63636% with 62 lines in your changes missing coverage. Please review.

Project coverage is 59.11%. Comparing base (bb0ad29) to head (b11c880).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
agent/cvms/api/grpc/client.go 47.47% 43 Missing and 9 partials ⚠️
agent/cvms/server/cvm.go 0.00% 8 Missing ⚠️
agent/service.go 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #375      +/-   ##
==========================================
- Coverage   59.57%   59.11%   -0.46%     
==========================================
  Files          54       55       +1     
  Lines        4574     4667      +93     
==========================================
+ Hits         2725     2759      +34     
- Misses       1564     1615      +51     
- Partials      285      293       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drasko drasko merged commit cef9cbb into ultravioletrs:main Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Report agent state to cloud Bug: Agent connection to cvms server does not persist
4 participants