COCOS-365-Add igvm measurement #379
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #379 +/- ##
==========================================
- Coverage 59.57% 59.29% -0.29%
==========================================
Files 54 57 +3
Lines 4574 4761 +187
==========================================
+ Hits 2725 2823 +98
- Misses 1564 1640 +76
- Partials 285 298 +13 ☔ View full report in Codecov by Sentry. |
SammyOina
requested changes
Feb 24, 2025
SammyOina
requested changes
Feb 26, 2025
Comment on lines
+31
to
+43
| _, err := NewIgvmMeasurement("", nil, nil) | ||
| if err == nil { | ||
| t.Errorf("expected error for empty pathToFile, got nil") | ||
| } | ||
|
|
||
| igvm, err := NewIgvmMeasurement("/valid/path", nil, nil) | ||
| if err != nil { | ||
| t.Errorf("unexpected error: %v", err) | ||
| } | ||
| if igvm == nil { | ||
| t.Errorf("expected non-nil IgvmMeasurement") | ||
| } | ||
| } |
There was a problem hiding this comment.
use assertions for expectations
Comment on lines
+45
to
+89
| func TestIgvmMeasurement_Run_Success(t *testing.T) { | ||
| mockOutput := "measurement successful" // Ensure it's a **single-line output** | ||
|
|
||
| m := &IgvmMeasurement{ | ||
| pathToFile: "/valid/path", | ||
| execCommand: func(name string, arg ...string) *exec.Cmd { | ||
| cmd := exec.Command("sh", "-c", "echo '"+mockOutput+"'") // Single line output | ||
| return cmd | ||
| }, | ||
| } | ||
|
|
||
| err := m.Run("/mock/igvmBinary") | ||
| if err != nil { | ||
| t.Errorf("expected no error, got %v", err) | ||
| } | ||
| } | ||
|
|
||
| func TestIgvmMeasurement_Run_Error(t *testing.T) { | ||
| mockOutput := "some error occurred" | ||
|
|
||
| m := &IgvmMeasurement{ | ||
| pathToFile: "/invalid/path", | ||
| execCommand: func(name string, arg ...string) *exec.Cmd { | ||
| cmd := exec.Command("sh", "-c", "echo '"+mockOutput+"' && echo 'extra line' && exit 1") // Simulate multiline error | ||
| return cmd | ||
| }, | ||
| } | ||
|
|
||
| err := m.Run("/mock/igvmBinary") | ||
|
|
||
| if err == nil { | ||
| t.Errorf("expected an error, got nil") | ||
| } else if !strings.Contains(err.Error(), "error: "+mockOutput) { | ||
| t.Errorf("expected error message to contain 'error: %s', got: %s", mockOutput, err) | ||
| } | ||
| } | ||
|
|
||
| func TestIgvmMeasurement_Stop_NoProcess(t *testing.T) { | ||
| m := &IgvmMeasurement{} | ||
|
|
||
| err := m.Stop() | ||
| if err == nil || err.Error() != "no running process to stop" { | ||
| t.Errorf("expected 'no running process to stop' error, got: %v", err) | ||
| } | ||
| } |
There was a problem hiding this comment.
combine tests into a single test with multiple test cases as we do for other tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature because it adds the following functionality: Igvm measurement functionality
What does this do?
Change the CLI so it calculates the measurement based on the vTPM and OVMF used.
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
No, I have not included tests because I am waiting for the first review.
Did you document any new/modified feature?
No, I have not updated the documentation but I will focus on documentation next.