Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

position get_gap_vector should always ends a sentinel record like {id, -1} #4

Open
bguo068 opened this issue Dec 11, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@bguo068
Copy link
Member

bguo068 commented Dec 11, 2021

Adding a sentinel record is good for providing information about the end position of the last effective record. This is important when the last position is far away from the end of the chromosome, in which case the label is ambiguous for the range to the right of the last position.

https://github.com/gbinux/ibdtools/blob/cd8c10da7effa5d7d8c48309dcd956f1b6557fe2/include/positions.hpp#L99-L149

@bguo068
Copy link
Member Author

bguo068 commented Jun 4, 2022

one more issue size_t prev_label with for loop would be overwritten. It should be outside of the loop

@bguo068 bguo068 added the enhancement New feature or request label Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant