Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V15-RC1] TipTap RTE Config Feedback - Unable to remove toolbar button, redorder, delete group or row #17190

Open
warrenbuckley opened this issue Oct 4, 2024 · 7 comments
Labels
affected/v15 area/frontend state/needs-more-info We don't have enough information to give a good reply state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks type/bug

Comments

@warrenbuckley
Copy link
Contributor

warrenbuckley commented Oct 4, 2024

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

15.0.0-rc1

Bug summary

Using the TipTap Config editor, I am unable to do the following things

  • Move the toolbar item position in same group to reorder
  • Move the toolbar item to another group
  • Delete a single toolbar item from a group
  • Delete an entire group
  • Delete an entire row

Specifics

Recording.2024-10-04.123429.mp4

Steps to reproduce

See attached video

Expected result / actual result

That the operations to move, delete and reorder toolbar buttons


This item has been added to our backlog AB#44726

Copy link

github-actions bot commented Oct 4, 2024

Hi there @warrenbuckley!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

warrenbuckley added a commit to warrenbuckley/HacktoberfestActivityLog that referenced this issue Oct 4, 2024
nul800sebastiaan pushed a commit to umbraco/HacktoberfestActivityLog that referenced this issue Oct 4, 2024
@iOvergaard
Copy link
Contributor

Hi @warrenbuckley, the first item (sorting inside a toolbar group) is something I can reproduce, but not the others. I can't (yet) see your video, but do you not get a delete/trashbin button on each group and row?

@warrenbuckley
Copy link
Contributor Author

@iOvergaard I do get a trash button on the group and row, but clicking them does nothing.

@iOvergaard
Copy link
Contributor

iOvergaard commented Oct 4, 2024

Oh, interesting! Could you copy/paste your system information into the description, please?

copysysinfo.mp4

@iOvergaard
Copy link
Contributor

And do you get any error in the console, that you could share with us as well, please?

@iOvergaard iOvergaard added state/needs-more-info We don't have enough information to give a good reply area/frontend affected/v15 labels Oct 4, 2024
@warrenbuckley
Copy link
Contributor Author

Umbraco system information
--------------------------------
Server OS: Microsoft Windows 10.0.22631
Server Framework: .NET 9.0.0-rc.1.24431.7
Default Language: en-US
Umbraco Version: 15.0.0-rc1
Current Culture: en-US
Current UI Culture: en-US
Current Webserver: IIS Express
Models Builder Mode: InMemoryAuto
Runtime Mode: BackofficeDevelopment
Debug Mode: True
Database Provider: System.Data.SQLite
Current Server Role: Single
Umbraco build version: 15.0.0-rc1+1180296
Server time offset: 00:00:00
Runtime mode: BackofficeDevelopment
Browser (user agent): Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/129.0.0.0 Safari/537.36 Edg/129.0.0.0
Browser language: en-GB
Browser location: https://localhost:44339/umbraco/section/content/dashboard/dashboardTabsContentIntro

Error when clicking button is in console
property-editor-ui-tiptap-toolbar-configuration.element.ts

property-editor-ui-tiptap-toolbar-configuration.element.ts:151  Uncaught TypeError: Cannot assign to read only property '0' of object '[object Array]'
    at Array.splice (<anonymous>)
    at m.M (property-editor-ui-tiptap-toolbar-configuration.element.ts:151:42)
    at m.<anonymous> (property-editor-ui-tiptap-toolbar-configuration.element.ts:226:21)
    at wt.handleEvent (index.js:15:6103)
M @ property-editor-ui-tiptap-toolbar-configuration.element.ts:151
(anonymous) @ property-editor-ui-tiptap-toolbar-configuration.element.ts:226
handleEvent @ index.js:15

image

@warrenbuckley
Copy link
Contributor Author

And clicking the delete for the row is this error/stack trace

property-editor-ui-tiptap-toolbar-configuration.element.ts:170  Uncaught TypeError: Cannot delete property '1' of [object Array]
    at Array.splice (<anonymous>)
    at m.S (property-editor-ui-tiptap-toolbar-configuration.element.ts:170:32)
    at m.<anonymous> (property-editor-ui-tiptap-toolbar-configuration.element.ts:206:21)
    at wt.handleEvent (index.js:15:6103)
S @ property-editor-ui-tiptap-toolbar-configuration.element.ts:170
(anonymous) @ property-editor-ui-tiptap-toolbar-configuration.element.ts:206
handleEvent @ index.js:15

@iOvergaard iOvergaard added the state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affected/v15 area/frontend state/needs-more-info We don't have enough information to give a good reply state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks type/bug
Projects
None yet
Development

No branches or pull requests

2 participants