From 556a34bc2c4c8aa3152654449e51887a356ccfa6 Mon Sep 17 00:00:00 2001 From: cloudboyd <77258023+cloudboyd@users.noreply.github.com> Date: Thu, 12 May 2022 23:43:41 +0700 Subject: [PATCH] docs(README): add missing = sign after not_statement (#51) * docs(README): add missing = sign after not_statement * Update changelog + fix versions support to 4.0.0+ Co-authored-by: Likhit-S Co-authored-by: Abdul Wahid --- .pre-commit-config.yaml | 4 ++-- CHANGELOG.md | 12 ++++++++++-- README.md | 8 +++----- examples/core/main.tf | 9 ++++++--- versions.tf | 2 +- 5 files changed, 22 insertions(+), 13 deletions(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index bfdd722..e59fa19 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -1,6 +1,6 @@ repos: - repo: https://github.com/pre-commit/pre-commit-hooks - rev: v4.1.0 + rev: v4.2.0 hooks: - id: check-added-large-files args: ['--maxkb=500'] @@ -18,7 +18,7 @@ repos: args: ['--allow-missing-credentials'] - id: trailing-whitespace - repo: https://github.com/antonbabenko/pre-commit-terraform - rev: v1.64.1 + rev: v1.71.0 hooks: - id: terraform_fmt - id: terraform_docs diff --git a/CHANGELOG.md b/CHANGELOG.md index 72ca417..303c270 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,7 +5,13 @@ All notable changes to this project will be documented in this file. ## [Unreleased] -- Added support for forwarded_ip_config inside of geo_match_statement +- docs(README): add missing = sign after not_statement + + + +## [3.7.0] - 2022-03-31 + +- Added support for forwarded_ip_config inside of geo_match_statement ([#49](https://github.com/umotif-public/terraform-aws-waf-webaclv2/issues/49)) @@ -163,7 +169,9 @@ All notable changes to this project will be documented in this file. - Initial commit -[Unreleased]: https://github.com/umotif-public/terraform-aws-waf-webaclv2/compare/3.6.0...HEAD +[Unreleased]: https://github.com/umotif-public/terraform-aws-waf-webaclv2/compare/3.7.0...HEAD +[3.7.0]: https://github.com/umotif-public/terraform-aws-waf-webaclv2/compare/3.6.0-patch-1...3.7.0 +[3.6.0-patch-1]: https://github.com/umotif-public/terraform-aws-waf-webaclv2/compare/3.6.0...3.6.0-patch-1 [3.6.0]: https://github.com/umotif-public/terraform-aws-waf-webaclv2/compare/3.5.0...3.6.0 [3.5.0]: https://github.com/umotif-public/terraform-aws-waf-webaclv2/compare/3.4.0...3.5.0 [3.4.0]: https://github.com/umotif-public/terraform-aws-waf-webaclv2/compare/3.3.0...3.4.0 diff --git a/README.md b/README.md index 92829ab..efe4c84 100644 --- a/README.md +++ b/README.md @@ -204,7 +204,7 @@ module "waf" { sampled_requests_enabled = false } - not_statement { + not_statement = { byte_match_statement = { field_to_match = { uri_path = "{}" @@ -326,8 +326,6 @@ Importantly, make sure that Amazon Kinesis Data Firehose is using a name startin ## Authors Module managed by: -* [Marcin Cuber](https://github.com/marcincuber) [LinkedIn](https://www.linkedin.com/in/marcincuber/) -* [Sean Pascual](https://github.com/seanpascual) [LinkedIn](https://www.linkedin.com/in/sean-edward-pascual) * [Abdul Wahid](https://github.com/Ohid25) [LinkedIn](https://www.linkedin.com/in/abdul-wahid/) @@ -336,13 +334,13 @@ Module managed by: | Name | Version | |------|---------| | [terraform](#requirement\_terraform) | >= 0.13.0 | -| [aws](#requirement\_aws) | >= 3.67.0 | +| [aws](#requirement\_aws) | >= 4.0.0 | ## Providers | Name | Version | |------|---------| -| [aws](#provider\_aws) | >= 3.67.0 | +| [aws](#provider\_aws) | >= 4.0.0 | ## Modules diff --git a/examples/core/main.tf b/examples/core/main.tf index a495e59..17d5bed 100644 --- a/examples/core/main.tf +++ b/examples/core/main.tf @@ -9,8 +9,11 @@ data "aws_vpc" "default" { default = true } -data "aws_subnet_ids" "all" { - vpc_id = data.aws_vpc.default.id +data "aws_subnets" "all" { + filter { + name = "vpc-id" + values = [data.aws_vpc.default.id] + } } ##### @@ -24,7 +27,7 @@ module "alb" { load_balancer_type = "application" internal = false vpc_id = data.aws_vpc.default.id - subnets = data.aws_subnet_ids.all.ids + subnets = data.aws_subnets.all.ids } ##### diff --git a/versions.tf b/versions.tf index abb8f92..f2637db 100644 --- a/versions.tf +++ b/versions.tf @@ -2,6 +2,6 @@ terraform { required_version = ">= 0.13.0" required_providers { - aws = ">= 3.67.0" + aws = ">= 4.0.0" } }