forked from import-js/eslint-plugin-import
-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
import/order sorting specifiers, named imports #225
Labels
Comments
PR welcome to port! |
falkenhawk
added a commit
to ovos/coding-standard
that referenced
this issue
Jan 20, 2025
https://perfectionist.dev/rules/sort-named-imports https://perfectionist.dev/rules/sort-named-exports We had named imports sorted in v1 when tslint was taking care of that. But it got lost during migration to eslint, as I wrongly assumed that import/order will take care of that. Later on, the support for sorting named imports (but still not exports) was added to the original eslint-plugin-import import-js/eslint-plugin-import#3043 but we have switched to eslint-plugin-import-x since and the porting request of that feature is still pending. un-ts/eslint-plugin-import-x#225 We could consider switching back to eslint-plugin-import but it still has a set of its own, still unresolved issues. Instead, I decided to try eslint-plugin-perfectionist and the sorting rules from that. Note we are sticking with import/order for sorting and grouping imports for the time being, as more time would be needed to convert the sorting and grouping config to achieve similar behaviour with the perfectionist/sort-imports rule. There is also perfectionist/sort-exports rule, but it does not provide config options to define grouping and custom sorting, to achieve similar behaviour to import/order with our custom config applied, so for now we won't enforce that rule.
falkenhawk
added a commit
to ovos/coding-standard
that referenced
this issue
Jan 20, 2025
https://perfectionist.dev/rules/sort-named-imports https://perfectionist.dev/rules/sort-named-exports We had named imports sorted in v1 when tslint was taking care of that. But it got lost during migration to eslint, as I wrongly assumed that import/order will take care of that. Later on, the support for sorting named imports (but still not exports) was added to the original eslint-plugin-import import-js/eslint-plugin-import#3043 but we have switched to eslint-plugin-import-x since and the porting request of that feature is still pending. un-ts/eslint-plugin-import-x#225 We could consider switching back to eslint-plugin-import but it still has a set of its own, still unresolved issues. Instead, I decided to try eslint-plugin-perfectionist and the sorting rules from that. Note we are sticking with import/order for sorting and grouping imports for the time being, as more time would be needed to convert the sorting and grouping config to achieve similar behaviour with the perfectionist/sort-imports rule. There is also perfectionist/sort-exports rule, but it does not provide config options to define grouping and custom sorting, to achieve similar behaviour to import/order with our custom config applied, so for now we won't enforce that rule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
hi, is porting over import-js#3043 in plans?
original issues: import-js#1787 and import-js#2553
from the description of the linked PR:
Reports error:
Fixed code:
The text was updated successfully, but these errors were encountered: