Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Old copies of privacy.sexy installers are being stored in private var folders #417

Open
jvk2 opened this issue Aug 24, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@jvk2
Copy link

jvk2 commented Aug 24, 2024

Description

I found twelve files such as /private/var/folders/yd/p9cfbbhj68d_92kqm47nt2qr0000gp/privacy.sexy/0.12.5-installer.dmg
Together they occupy 1.61 GB.

Reproduction steps

These are probably downloaded by the program.

Expected behavior

I would expect these dmg files to be cleared after installation or a version check.

Screenshots

No response

privacy.sexy environment details

No response

Additional context

No response

@jvk2 jvk2 added the bug Something isn't working label Aug 24, 2024
@undergroundwires
Copy link
Owner

I can reproduce this.

Running ls /var/folders/*/*/privacy.sexy/*-installer.dmg gives me:

/var/folders/d0/fs0nfsms75j4qqnjp7tf28gw0000gn/privacy.sexy/0.12.8-installer.dmg
/var/folders/d0/fs0nfsms75j4qqnjp7tf28gw0000gn/privacy.sexy/0.12.9-installer.dmg
/var/folders/d0/fs0nfsms75j4qqnjp7tf28gw0000gn/privacy.sexy/0.13.0-installer.dmg
/var/folders/d0/fs0nfsms75j4qqnjp7tf28gw0000gn/privacy.sexy/0.13.1-installer.dmg
/var/folders/d0/fs0nfsms75j4qqnjp7tf28gw0000gn/privacy.sexy/0.13.3-installer.dmg
/var/folders/d0/fs0nfsms75j4qqnjp7tf28gw0000gn/privacy.sexy/0.13.6-installer.dmg

Thank you for detecting this.

The path is received from operating system as temporary folder, which is by standard should be cleaned up regularly by the operating system. I don't understand why it does not behave this way, but I will fix it.

I think it would be better to have a more predictable path for privacy.sexy, using application data or something and clear this directory on every launch if any files exist. I will think more about this an fix in a patch.

As temporary solution, you can clean these up by running this command in a terminal window:

rm -v /var/folders/*/*/privacy.sexy/*-installer.dmg

@jvk2
Copy link
Author

jvk2 commented Aug 26, 2024

You're welcome. By the way, the only other program I've used recently that stores files here is Graphic Converter. It works for them: I've used it for years and there are only files from the last two days.

undergroundwires added a commit that referenced this issue Oct 7, 2024
This fixes issue #417 where autoupdate installer files were not deleted
on macOS, leading to accumulation of old installers.

Key changes:

- Store update files in application-specific directory
- Clear update files directory on every app launch

Other supporting changes:

- Refactor file system operations to be more testable and reusable
- Improve separation of concerns in directory management
- Enhance dependency injection for auto-update logic
- Fix async completion to support `await` operations
- Add additional logging and revise some log messages during updates
undergroundwires added a commit that referenced this issue Oct 7, 2024
This fixes issue #417 where autoupdate installer files were not deleted
on macOS, leading to accumulation of old installers.

Key changes:

- Store update files in application-specific directory
- Clear update files directory on every app launch

Other supporting changes:

- Refactor file system operations to be more testable and reusable
- Improve separation of concerns in directory management
- Enhance dependency injection for auto-update logic
- Fix async completion to support `await` operations
- Add additional logging and revise some log messages during updates
@undergroundwires
Copy link
Owner

I did the following changes: privacy.sexy does no longer trust OS to cleanup its temporary directories, stores update installation files at $HOME/Library/Application Support/privacy.sexy/updates. It also cleans up contents of this directory on every application launch. It will be released in next patch release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants