New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plot_erp AoG breaking #245

Open

behinger opened this issue Sep 26, 2024 · 1 comment

Member

behinger commented Sep 26, 2024

Breaking: All colormap properties for continuous color scales need to be passed via scales now, and not through visual. This is to have central control over the scale as it can be used by multiple visuals simultaneously.

Please double check that all breaking changes from AoG have been accounted for in UnfoldMakie.jl

Member Author

behinger commented Sep 26, 2024

UnfoldMakie.jl/src/plot_erp.jl

Line 145 in 9e54a62

drawing = draw!(f_grid, plot_equation; axis = config.axis)

This line should be changed; the colormap now needs to go into the draw function via scales

This is at odds with our PlotConfig; not sure how to harmonize this with all other plots. Very unfortunate.

vladdez mentioned this issue

Prepublication #247

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment