Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU4X and plural_rules: locale "root" gives an error. #307

Closed
sven-oly opened this issue Sep 19, 2024 · 4 comments
Closed

ICU4X and plural_rules: locale "root" gives an error. #307

sven-oly opened this issue Sep 19, 2024 · 4 comments
Assignees

Comments

@sven-oly
Copy link
Collaborator

No description provided.

@sven-oly
Copy link
Collaborator Author

This data results in an error with {"test_type": "plural_rules", "option":"root"}

{"test_type": "plural_rules", "locale":"root","label":"308","type":"cardinal","plural_type":"cardinal","sample":"15","hexhash":"3c749a7b7dfd26b68537283d16e03d72b6f869d4"}

Should these tests with locale "root" be dropped or mapped to "und" or something else?

@sffc
Copy link
Member

sffc commented Nov 11, 2024

Please just remove locale "root" from the test data.

@sffc sffc added this to the 2024 Q4 ⟨P1⟩ milestone Nov 11, 2024
@echeran
Copy link
Collaborator

echeran commented Nov 11, 2024

Removing root as a locale from test data is suggested in #318

@sven-oly
Copy link
Collaborator Author

This was fixedtoday in PR#341.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants