-
-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICU-22722 Revised ICU4J API doc process to modern tools #2969
Conversation
This goes into "main" which is now for 76, so you can't use the 75 BRS ticket. Please use |
2da4ece
to
acb80b3
Compare
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
docs/processes/release/tasks/docs.md
Outdated
|
||
#### Alternative method: | ||
Next, update the documents for this version: | ||
* Copy the fulljavadoc.jar to the to icu-docs/apidoc directory, either dev (for release candidates) or released (for public distribution). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo?
* Copy the fulljavadoc.jar to the to icu-docs/apidoc directory, either dev (for release candidates) or released (for public distribution). | |
* Copy the full javadoc.jar to the to icu-docs/apidoc directory, either dev (for release candidates) or released (for public distribution). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, the file is actually called "icu4j-75_1-fulljavadoc.jar". There's another file "icu4j-75_1-javadoc.jar" which is not the one to use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, there are 2 javadoc files, icu4j-75_1-javadoc.jar and icu4j-75_1-fulljavadoc.jar. The "full" one is what should be used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be best to document it as icu4j-<version>-fulljavadoc.jar
then.
I think it would avoid confusion.
In the longer run I think that creating jar + unzipped folder should be done by the script.
No reason to do it by hand.
8c8082f
to
9d90c44
Compare
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
Add how to use release_tools/github_release.sh.
Also detailed how to update the files in icu-docs/apidoc
Checklist