ICU-22721 Prevent inconsistent ICU4J Maven deploys via CI

[echeran]

Update the CI workflow that deploys Maven artifacts to Github for ICU4J so that:

• We don't publish the icu4j artifact to Github for release (non-snapshot) versions. This preserves Maven Central as the single source of truth for icu4j artifacts for release versions
  • Note: we keep the current behavior for snapshot versions, which is to publish to Github
• We automatically prevent any manual attempts to publish a release version artifact

Trial runs in my personal fork:

• succeeding workflow run of the PR branch, triggered manually: https://github.com/echeran/icu/actions/runs/8730613164/job/23954716091
  • the condition execution of steps within the job shows that the workflow output variables are being captured as expected
• a previous iteration that failed when the version number looked like a release version (1), triggered manually: https://github.com/echeran/icu/actions/runs/8730537899/job/23954536566
  • the automatic check is activated to prevent a manual deploy of a release version artifact

Checklist

• Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22721
• Required: The PR title must be prefixed with a JIRA Issue number.
• Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
• Required: Each commit message must be prefixed with a JIRA Issue number.
• Issue accepted (done by Technical Committee after discussion)
• Tests included, if applicable
• API docs and/or User Guide docs changed or added, if applicable

[mihnita]

Nitpicking on words.

• "manual" => my understanding (from the email thread) is that this can also run automatically, in some cases. So it is not always "manual"?
• "deploys" vs "deployments"

Thank you!
M.

Mihai

[mihnita]

Suggested change

	- name: Prevent manual deploys of full release
	- name: Prevent deployments of release versions

[mihnita]

Suggested change

	echo "Manual deploys of publishing artifacts should only be done for snapshot versions"
	echo "Deployments of the icu4j artifacts should only be done for snapshot versions"

[jira-pull-request-webhook]

Notice: the branch changed across the force-push!

• .github/workflows/maven.yaml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

[echeran]

Nitpicking on words.

• "manual" => my understanding (from the email thread) is that this can also run automatically, in some cases. So it is not always "manual"?
• "deploys" vs "deployments"

Thank you! M.

Mihai

I made a few wording changes, including the "deploy" -> "deployment" change.

I kept "manual" because that is used in a step that is an additional early exit check to provide a more explanatory warning to users of what is & isn't an appropriate usage of artifact deployment in relation to versions. This extra check explicitly addresses the scenario that triggered the whole email thread in the first place. If not for the above reasons, then yes, that particular step is not entirely necessary from a technical perspective because this PR down below in later steps already prevents publishing of icu4j for snapshot releases.

[jira-pull-request-webhook]

Notice: the branch changed across the force-push!

• .github/workflows/maven.yaml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot