Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22922 BRS77 Update ICU4J serialization test data #3410

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

mihnita
Copy link
Contributor

@mihnita mihnita commented Feb 21, 2025

BRS 77 sheet, line 65, "Add ICU4J serialization test data"

Checklist

  • Required: Issue filed: ICU-22922
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@markusicu
Copy link
Member

Should we delete the ICU 73 data like @yumaoka did in #3220 ?

I also don't know why we still have ICU 3.6 data, but I guess that's for another day.

@mihnita mihnita force-pushed the mihai_serialization_data branch from e39f9a2 to 5ffcfd3 Compare February 21, 2025 19:36
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4j/main/core/src/test/resources/com/ibm/icu/dev/test/serializable/data/ICU_73.1/com.ibm.icu.message2.Mf2DataModel$OrderedMap.dat is now changed in the branch
  • icu4j/main/core/src/test/resources/com/ibm/icu/dev/test/serializable/data/ICU_73.1/com.ibm.icu.text.ChineseDateFormat.dat is now changed in the branch
  • icu4j/main/core/src/test/resources/com/ibm/icu/dev/test/serializable/data/ICU_73.1/com.ibm.icu.text.ChineseDateFormatSymbols.dat is now changed in the branch
  • icu4j/main/core/src/test/resources/com/ibm/icu/dev/test/serializable/data/ICU_73.1/com.ibm.icu.text.DateFormat.dat is now changed in the branch
  • icu4j/main/core/src/test/resources/com/ibm/icu/dev/test/serializable/data/ICU_73.1/com.ibm.icu.text.DateFormatSymbols.dat is now changed in the branch
  • icu4j/main/core/src/test/resources/com/ibm/icu/dev/test/serializable/data/ICU_73.1/com.ibm.icu.text.SimpleDateFormat.dat is now changed in the branch
  • icu4j/main/core/src/test/resources/com/ibm/icu/dev/test/serializable/data/ICU_73.1/com.ibm.icu.util.BuddhistCalendar.dat is now changed in the branch
  • icu4j/main/core/src/test/resources/com/ibm/icu/dev/test/serializable/data/ICU_73.1/com.ibm.icu.util.EthiopicCalendar.dat is now changed in the branch
  • icu4j/main/core/src/test/resources/com/ibm/icu/dev/test/serializable/data/ICU_73.1/com.ibm.icu.util.IndianCalendar.dat is now changed in the branch
  • icu4j/main/core/src/test/resources/com/ibm/icu/dev/test/serializable/data/ICU_73.1/com.ibm.icu.util.IslamicCalendar.dat is now changed in the branch
  • icu4j/main/core/src/test/resources/com/ibm/icu/dev/test/serializable/data/ICU_73.1/com.ibm.icu.util.JapaneseCalendar.dat is now changed in the branch
  • icu4j/main/core/src/test/resources/com/ibm/icu/dev/test/serializable/data/ICU_73.1/com.ibm.icu.util.TaiwanCalendar.dat is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@mihnita
Copy link
Contributor Author

mihnita commented Feb 21, 2025

Should we delete the ICU 73 data like @yumaoka did in #3220 ?

I was thinking to do that in the release BRS.
But sure, no problem.

I also don't know why we still have ICU 3.6 data, but I guess that's for another day.

The doc says "You may delete very old versions of the API signature files. We keep last 5 versions including a new release and ICU_3.6."

I don't know why, but...

@mihnita mihnita merged commit 9f51147 into unicode-org:main Feb 21, 2025
15 checks passed
@yumaoka
Copy link
Member

yumaoka commented Feb 22, 2025

ICU_3.6 is the starting point that we guaranteed serialization compatibility. This is the reason why we keep ICU_3.6 data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants