ICU-22922 BRS77 Fix version in release-icu4c-ubuntu.yml #3412
Conversation
Will need a proper fix, but let's just release this for now.
| mv icu4c/source/dist/icu4c-77_1-d* ${RELEASE_FOLDER} | ||
| mv icu4c/source/dist/icu4c-77_1-src.* ${RELEASE_FOLDER} |
There was a problem hiding this comment.
Not really.
There are other files in that folder source/dist folder that we don't want to publish.
I'll fix it, but not now.
I want to get the release out.
There was a problem hiding this comment.
This is the content of the dist folder:
icu4c-77_1-data-bin-l.zip
icu4c-77_1-data.zip
icu4c-77_1-docs.zip
icu4c-77_1-release-77-rc-data.zip
icu4c-77_1-release-77-rc-docs.zip
icu4c-77_1-release-77-rc-src.tgz
icu4c-77_1-release-77-rc-src.zip
icu4c-77_1-src.tgz
icu4c-77_1-src.zip
icu4c-data.zip@
icu4c-docs.zip@
icu4c-src.tgz@
icu4c-src.zip@
tmp/
icu4c-77_1-data-bin-b.zip
The "files" ending in @ are symbolic links. Which we don't publish.
And we don't want the icu4c-77_1-src.* files either (because GitHub does that automatically).
And icu4c-77_1-release-* are the same as the ones without -release-
So I can't just mv icu4c-*
There was a problem hiding this comment.
I have it on my wish-list to unify the naming.
Between C, Java, and the rust data export tool we use: 76_1rc, 76.1rc, 76-rc
And if we really need one file 3 times (once as a link):
icu4c-77_1-data.zip
icu4c-77_1-release-77-rc-data.zip
icu4c-data.zip@
And the sources.
There was a problem hiding this comment.
do the version update instructions need an addition?
There was a problem hiding this comment.
do the version update instructions need an addition?
No. I would rather do it properly, with no version dependency.
So there will be no need for instructions.
(some kind of wildcard, tbd)
|
FYI: I re-opened the rc ticket for this PR. |
Thank you. I think we should not close the RC ticked until all BRS items are done. |
it looked like they were... |
Checklist