Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-23060 Fix heap-buffer-overflow when UnicodeString size too large #3416

Merged
merged 1 commit into from
Feb 25, 2025
Merged

ICU-23060 Fix heap-buffer-overflow when UnicodeString size too large #3416

merged 1 commit into from
Feb 25, 2025

Conversation

FrankYFTang
Copy link
Contributor

@FrankYFTang FrankYFTang commented Feb 25, 2025 •
edited
Loading

Checklist

  • Required: Issue filed: ICU-23060
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

roubert
roubert previously requested changes Feb 25, 2025
View reviewed changes
markusicu
markusicu requested changes Feb 25, 2025
View reviewed changes
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please re-target this PR to the maint/maint-77 branch

@markusicu markusicu self-assigned this Feb 25, 2025
@FrankYFTang FrankYFTang force-pushed the ICU-23060-out-of-bound branch from 9136d08 to c804c09 Compare February 25, 2025 20:25
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • .github/workflows/release-icu4c-ubuntu.yml is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@FrankYFTang FrankYFTang changed the base branch from main to maint/maint-77 February 25, 2025 20:29
@FrankYFTang FrankYFTang force-pushed the ICU-23060-out-of-bound branch from cf743c2 to c728002 Compare February 25, 2025 21:04
richgillam
richgillam approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@richgillam richgillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markusicu markusicu dismissed roubert’s stale review February 25, 2025 23:18

Frank made the test code compile conditionally, on a subset of platforms where it works in the CI checks. We can restrict further if needed.

@FrankYFTang FrankYFTang merged commit 0b88b1c into unicode-org:maint/maint-77 Feb 25, 2025
94 checks passed
@FrankYFTang FrankYFTang deleted the ICU-23060-out-of-bound branch February 25, 2025 23:36
@roubert
Copy link
Member

roubert commented Feb 26, 2025

This seems to have broken the Exhaustive Tests for ICU:

https://github.com/unicode-org/icu/actions/runs/13533127126/job/37819569299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusicu markusicu markusicu approved these changes

@richgillam richgillam richgillam approved these changes

@roubert roubert Awaiting requested review from roubert

Assignees

@markusicu markusicu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FrankYFTang @roubert @markusicu @richgillam