Skip to content

Commit

Permalink
Tightening deps allowlist (#4565)
Browse files Browse the repository at this point in the history
`icu_provider_adapters` should not generally be used by components, it's
for callers to build data pipelines.
  • Loading branch information
robertbastian authored Jan 31, 2024
1 parent 62e6cc6 commit b4a2caf
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions tools/depcheck/src/allowlist.rs
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ pub const BASIC_RUNTIME_DEPS: &[&str] = &[
// ICU4X utils
"calendrical_calculations",
"fixed_decimal",
"icu_provider_adapters", // not included in icu, but needed generally
"icu_provider",
"litemap",
"tinystr",
Expand Down Expand Up @@ -113,7 +112,12 @@ pub const EXTRA_RYU_DEPS: &[&str] = &["ryu"];

/// Runtime dependencies allowed when building `icu_capi`
/// This shuld almost never change
pub const EXTRA_CAPI_DEPS: &[&str] = &["diplomat-runtime", "icu_capi", "unicode-bidi"];
pub const EXTRA_CAPI_DEPS: &[&str] = &[
"diplomat-runtime",
"icu_capi",
"icu_provider_adapters",
"unicode-bidi",
];

/// Build-time dependencies allowed when building `icu_capi`
/// This may change as Diplomat evolves, but care should be taken to keep this small
Expand Down Expand Up @@ -143,6 +147,7 @@ pub const EXTRA_DATAGEN_DEPS: &[&str] = &[
"elsa",
"erased-serde",
"icu_codepointtrie_builder",
"icu_provider_adapters",
"itertools",
"itoa",
"matrixmultiply",
Expand Down

0 comments on commit b4a2caf

Please sign in to comment.