From b4a2caf597ee3ecaf5c9f96a2dad25a9d18ecea6 Mon Sep 17 00:00:00 2001 From: Robert Bastian <4706271+robertbastian@users.noreply.github.com> Date: Wed, 31 Jan 2024 17:45:21 +0100 Subject: [PATCH] Tightening deps allowlist (#4565) `icu_provider_adapters` should not generally be used by components, it's for callers to build data pipelines. --- tools/depcheck/src/allowlist.rs | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tools/depcheck/src/allowlist.rs b/tools/depcheck/src/allowlist.rs index 08d3a4dda6b..f52020fab72 100644 --- a/tools/depcheck/src/allowlist.rs +++ b/tools/depcheck/src/allowlist.rs @@ -26,7 +26,6 @@ pub const BASIC_RUNTIME_DEPS: &[&str] = &[ // ICU4X utils "calendrical_calculations", "fixed_decimal", - "icu_provider_adapters", // not included in icu, but needed generally "icu_provider", "litemap", "tinystr", @@ -113,7 +112,12 @@ pub const EXTRA_RYU_DEPS: &[&str] = &["ryu"]; /// Runtime dependencies allowed when building `icu_capi` /// This shuld almost never change -pub const EXTRA_CAPI_DEPS: &[&str] = &["diplomat-runtime", "icu_capi", "unicode-bidi"]; +pub const EXTRA_CAPI_DEPS: &[&str] = &[ + "diplomat-runtime", + "icu_capi", + "icu_provider_adapters", + "unicode-bidi", +]; /// Build-time dependencies allowed when building `icu_capi` /// This may change as Diplomat evolves, but care should be taken to keep this small @@ -143,6 +147,7 @@ pub const EXTRA_DATAGEN_DEPS: &[&str] = &[ "elsa", "erased-serde", "icu_codepointtrie_builder", + "icu_provider_adapters", "itertools", "itoa", "matrixmultiply",