Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide what to do about HourCycle::H24 #6220

Open
sffc opened this issue Mar 4, 2025 · 5 comments
Open

Decide what to do about HourCycle::H24 #6220

sffc opened this issue Mar 4, 2025 · 5 comments
Labels
C-locale Component: Locale identifiers, BCP47 discuss-priority Discuss at the next ICU4X meeting

Comments

@sffc
Copy link
Member

sffc commented Mar 4, 2025

CLDR looks ready to deprecate it based on feedback from @hsivonen: https://unicode-org.atlassian.net/browse/CLDR-18303

We should decide what to do about it in the HourCycle enum for 2.0.

@zbraniecki @hsivonen

@sffc sffc added C-locale Component: Locale identifiers, BCP47 discuss-priority Discuss at the next ICU4X meeting labels Mar 4, 2025
@sffc sffc added this to the ICU4X 2.0 ⟨P1⟩ milestone Mar 4, 2025
@zbraniecki
Copy link
Member

Let's remove it.

@sffc
Copy link
Member Author

sffc commented Mar 6, 2025

Let's remove it.

What happens if someone hands us a locale with -u-hc-h24?

@zbraniecki
Copy link
Member

We treat it as an invalid value and use the default for a given locale. I think that's the same as if the customer passed -u-hc-h25.

@sffc
Copy link
Member Author

sffc commented Mar 6, 2025

Does Locale --> Preferences conversion do this fallback (leaving None in place of unknown values)? If so I am totally onboard with this. I just would like to avoid throwing weird data-driven exceptions.

@sffc
Copy link
Member Author

sffc commented Mar 6, 2025

  • @robertbastian We already support it and it is in UTS 35. So let's keep it
  • @sffc It has no use cases, it is a big footgun, and CLDR plans to deprecate it. I think we should remove it now and @zbraniecki agrees.

Conclusion: 2.0-stretch, OK to remove.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-locale Component: Locale identifiers, BCP47 discuss-priority Discuss at the next ICU4X meeting
Projects
None yet
Development

No branches or pull requests

3 participants