Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UtcOffsetCalculator should be UtcOffsetsCalculator #6236

Open
sffc opened this issue Mar 6, 2025 · 2 comments
Open

UtcOffsetCalculator should be UtcOffsetsCalculator #6236

sffc opened this issue Mar 6, 2025 · 2 comments
Labels
C-datetime Component: datetime, calendars, time zones S-tiny Size: Less than an hour (trivial fixes)

Comments

@sffc
Copy link
Member

sffc commented Mar 6, 2025

We don't calculate a UTC Offset. We calculate a set of possible UTC Offsets. This is confusing and just stumbled on it. We should be consistent with the "s" at the end of UtcOffsets.

@robertbastian

@sffc sffc added the C-datetime Component: datetime, calendars, time zones label Mar 6, 2025
@sffc sffc added this to the ICU4X 2.0 ⟨P1⟩ milestone Mar 6, 2025
@sffc sffc added the needs-approval One or more stakeholders need to approve proposal label Mar 6, 2025
@robertbastian
Copy link
Member

The way I think of this is that this type calculates the UTC offset of a zone. It might throw in the DST offset if the zone uses one, but most zones don't.

@sffc
Copy link
Member Author

sffc commented Mar 6, 2025

  • @sffc It looks like it calculates the offset from my datetime. But that isn't what it does.
  • @robertbastian It doesn't calculate anything. It is just a lookup.
  • @sffc Maybe VariantOffsets instead of UtcOffsets?
  • @robertbastian Ok. And VariantOffsetsCalculator is fine.

@sffc sffc added S-tiny Size: Less than an hour (trivial fixes) and removed needs-approval One or more stakeholders need to approve proposal labels Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-datetime Component: datetime, calendars, time zones S-tiny Size: Less than an hour (trivial fixes)
Projects
None yet
Development

No branches or pull requests

2 participants