Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update twoxhash to 2.0 #5709

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Update twoxhash to 2.0 #5709

merged 2 commits into from
Feb 26, 2025

Conversation

Manishearth
Copy link
Member

Supersedes #5706

@Manishearth Manishearth requested review from sffc and a team as code owners October 18, 2024 19:36
@Manishearth Manishearth mentioned this pull request Oct 18, 2024
Closed
@sffc
Copy link
Member

sffc commented Oct 18, 2024

Not currently compatible with the repo MSRV.

@Manishearth
Copy link
Member Author

Yep, I plan to leave this PR open for now

@Manishearth Manishearth marked this pull request as draft October 18, 2024 19:53
@robertbastian
Copy link
Member

1.81 MSRV is far away, can we not keep draft PRs cluttering the repo for extended periods of time?

@sffc
Copy link
Member

sffc commented Oct 21, 2024

I think it's fine. We have old draft PRs.

@robertbastian
Copy link
Member

And we should clean them up. Most are more work to rebase than to do again, many are not even compatible with current designs anymore.

@sffc sffc removed their request for review November 2, 2024 00:39
@robertbastian
Copy link
Member

@Manishearth we are now at 1.81 MSRV

@Manishearth Manishearth marked this pull request as ready for review February 24, 2025 18:14
@Manishearth
Copy link
Member Author

Good catch, thanks!

@Manishearth Manishearth mentioned this pull request Feb 26, 2025
Merged
younies
younies previously approved these changes Feb 26, 2025
View reviewed changes
@Manishearth Manishearth requested a review from younies February 26, 2025 01:07
@robertbastian robertbastian merged commit 536010c into unicode-org:main Feb 26, 2025
28 checks passed
@Manishearth Manishearth deleted the twoxhash branch February 26, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertbastian robertbastian robertbastian approved these changes

@younies younies Awaiting requested review from younies

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Manishearth @sffc @robertbastian @younies