Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modularized functions to the DDD user guide #2606

Open
purva-thakre opened this issue Dec 19, 2024 · 5 comments · May be fixed by #2618
Open

Add modularized functions to the DDD user guide #2606

purva-thakre opened this issue Dec 19, 2024 · 5 comments · May be fixed by #2618
Assignees
Labels
ddd Digital Dynamical Decoupling good first issue Good for newcomers
Milestone

Comments

@purva-thakre
Copy link
Collaborator

Follow up from #2562

After newer modularized functions are added in ddd/, we want to make sure the newer functions are demoed in the user guide for DDD.

@purva-thakre purva-thakre added ddd Digital Dynamical Decoupling good first issue Good for newcomers labels Dec 19, 2024
@purva-thakre purva-thakre added this to the 0.43.0 milestone Dec 20, 2024
@Shivansh20128
Copy link
Contributor

Hi @purva-thakre! Can you assign this to me?

@Shivansh20128
Copy link
Contributor

Hi! @purva-thakre I have a doubt regarding these new functions.
So, the function generate_circuits_with_ddd generates a list of circuits and it needs a base circuit, a rule, and the number of trials as parameters. And we can provide the rule as per our choice as xx or yy etc. That will generate a new sample circuit with the DDD sequence plugged into the original circuit. Until here, it is fine.
But now to execute this circuit, we will call execute_with_ddd, which will take our new sample circuit, an executor, and a rule as parameters. This makes me question how the 'rule' is functioning here because we already have a DDD sequence plugged into the circuit. Are we plugging in a DDD sequence again while executing?
Since these parameters are not optional, we need to pass something as a rule for both these functions.

@purva-thakre
Copy link
Collaborator Author

Pinging @bdg221 to answer the above as you worked on the modularized functions for DDD.

@bdg221
Copy link
Collaborator

bdg221 commented Feb 18, 2025

Hey @Shivansh20128, the point of the modularized functions is so that users don't have to call execute_with_ddd which is more of a black box. Instead, we have broken the pieces out (generate_circuits_with_ddd and combine_results) and along with calling the executor, the users can perform the function of execute_with_ddd manually.

If you check the ZNE example, you can see how the circuits are generated and execute(circuit) is called.

@Shivansh20128
Copy link
Contributor

Got it. I was unaware of the function execute(circuit). Thank you @bdg221.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ddd Digital Dynamical Decoupling good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants