Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid: Long words inside grid__item cause incorrect widths #122

Open
chuckhendo opened this issue Jun 18, 2018 · 2 comments
Open

Grid: Long words inside grid__item cause incorrect widths #122

chuckhendo opened this issue Jun 18, 2018 · 2 comments
Assignees

Comments

@chuckhendo
Copy link
Contributor

A long word inside of a grid__item causes the grid__item to be wider than it's flex-basis indicates it should be. One way to fix this seems to be:

  1. Set width on grid__item to be the same as flex-basis
  2. Set word-wrap: break-word
  3. Find some way to hyphenate?
@Keale2
Copy link
Contributor

Keale2 commented Jun 18, 2018

I suspect any component with long words will break any component they are used in, so we may want to consider a solution that addresses more than grid__item.

We can consider hyphens: auto at a higher level.

@chuckhendo
Copy link
Contributor Author

@Keale2 Agreed. I think 2 and 3 could potentially be handled at a higher level. 1 still needs to be completed on this component in order for those to work properly though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants