-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor positioning and spacing of page-header component #78
Comments
As I was playing around with this, I'm starting to think that deriving the page-header height from one of it's children (namely the logo) isn't a bad thing. Here is a pen with that concept working to keep vertical alignment balanced for mobile and desktop: https://codepen.io/townivan/pen/pWOOjL?editors=1111 |
I've attempted some styling in this similar thinking to Willow imported from a precompiled css source: https://codepen.io/townivan/pen/YrRzEJ |
Here is some override css that fixes things in my project: .willow-page-header__content-controls { |
For testing purposes:
|
@bollinghball pointed out that the spacing of the menu/close button is off when you add the icon in. |
Note for the future: to fix the menu/close button spacing add |
Currently the height of the page-header is being set by margin from the header's sub-elements. Rework this to come from padding on the page-header and come up with a way to shift the sub-elements to the top or bottom when necessary.
The text was updated successfully, but these errors were encountered: