Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Styling] Add styling to 'Tags' #1160

Open
AllanOcelot opened this issue Feb 7, 2019 · 17 comments
Open

[Styling] Add styling to 'Tags' #1160

AllanOcelot opened this issue Feb 7, 2019 · 17 comments
Labels
discussion open-ended issues that haven't yet defined what needs to be worked on

Comments

@AllanOcelot
Copy link

At the moment we display 'Tags' as simple text links - of inconsistent sizes.

We should aim to have tags consistent, I have in mind something like github labels - a simple rectangle with rounded corners, a background colour and an easy to read text colour.

I'll experiment with this myself, but raising it as an issue incase anyone else would like to attempt with an easy to implement feature.
@ritwik12
Copy link
Collaborator

ritwik12 commented Feb 7, 2019

@AllanOcelot Great

@shiftkey shiftkey added the discussion open-ended issues that haven't yet defined what needs to be worked on label Feb 12, 2019
@User5842
Copy link

User5842 commented Mar 9, 2019

I've noticed that the popular tags also do not have any cursor: pointer declaration attached to their stylings. Other a tags on the page do have the style so it could be a good idea to add them here as well.

@stale

This comment has been minimized.

Sign in to view
@stale stale bot added the wontfix label Oct 16, 2019
@shiftkey shiftkey removed the wontfix label Oct 16, 2019
@subhromajumder
Copy link

Hello, is this issue still open? I would like to work on it.

@ritwik12
Copy link
Collaborator

@subhromajumder It is open, please go ahead!!

@subhromajumder
Copy link

Okay!

@subhromajumder
Copy link

I am making changes to the stylesheet but it is not showing up on the local (cloned) website. Why is that happening? I am sorry, this might be a stupid question, I am a first timer.

@dkbearsong
Copy link

Is this issue still open? If so I'd like to take a crack at it.

@priyanks25coder
Copy link

Is this issue still open? Wanted to work on it so..

@maryanamorato
Copy link

could you assign to me?

@Potato-29
Copy link

is this still open?

@ritwik12
Copy link
Collaborator

Yep this is still open

@JiGzSaw01
Copy link

Hi! can i try to work on it?

@ritwik12
Copy link
Collaborator

ritwik12 commented Aug 3, 2022

@JiGzSaw01 Sure

@cweave
Copy link
Contributor

cweave commented Oct 7, 2022

Here's a sample of what I did:

Light mode with python in an active state:
image

Dark mode with python in an active state:
image

I did the changes via code locally, so if y'all like it, its not much to make a PR or implement changes :)

cweave added a commit to cweave/up-for-grabs.net that referenced this issue Oct 8, 2022
@cweave
up-for-grabs#1160 add styling to popular tags
99e1fbd
cweave added a commit to cweave/up-for-grabs.net that referenced this issue Oct 8, 2022
@cweave
up-for-grabs#1160 adjust popular tags container for better responsive…
43ca68d 
… styling
@cweave cweave mentioned this issue Oct 8, 2022
Merged
cweave added a commit to cweave/up-for-grabs.net that referenced this issue Oct 11, 2022
@cweave
up-for-grabs#1160 reinclude list for popular tags rendering
e902028
cweave added a commit to cweave/up-for-grabs.net that referenced this issue Oct 23, 2022
@cweave
up-for-grabs#1160 update selector in main.js to selector link (update…
59b1a04 
… from div restructure)
cweave added a commit to cweave/up-for-grabs.net that referenced this issue Oct 23, 2022
@cweave
up-for-grabs#1160 add styling to popular tags
c72a525
cweave added a commit to cweave/up-for-grabs.net that referenced this issue Oct 23, 2022
@cweave
up-for-grabs#1160 adjust popular tags container for better responsive…
dd588b4 
… styling
cweave added a commit to cweave/up-for-grabs.net that referenced this issue Oct 23, 2022
@cweave
up-for-grabs#1160 reinclude list for popular tags rendering
1c2b7ed
cweave added a commit to cweave/up-for-grabs.net that referenced this issue Oct 23, 2022
@cweave
up-for-grabs#1160 update selector in main.js to selector link (update…
d6fad2b 
… from div restructure)
ritwik12 pushed a commit that referenced this issue Dec 19, 2022
@cweave
#1160 add styling to popular tags (#3460)
a6a3178 
* #1160 add styling to popular tags

* #1160 adjust popular tags container for better responsive styling

* #1160 reinclude list for popular tags rendering

* #1160 update selector in main.js to selector link (update from div restructure)
@Sam10-debug
Copy link

id like to work on this, can this be assigned to me please

@Tech-frank
Copy link

Can I join in this? I'm a first timer so...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion open-ended issues that haven't yet defined what needs to be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
14 participants
@shiftkey @AllanOcelot @cweave @ritwik12 @User5842 @priyanks25coder @subhromajumder @maryanamorato @Potato-29 @dkbearsong @Sam10-debug @JiGzSaw01 @Tech-frank and others