Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding extra/buntype package #112

Open
vmihailenco opened this issue Aug 19, 2021 · 7 comments
Open

Adding extra/buntype package #112

vmihailenco opened this issue Aug 19, 2021 · 7 comments
Assignees
Labels
enhancement New feature or request stale

Comments

@vmihailenco
Copy link
Member

@d-fal sorry for the late reaction, but what do you think about moving github.com/pgcontrib/bigint to github.com/uptrace/bun/buntype? So bigint.Bigint becomes buntype.Bigint.

@d-fal
Copy link
Collaborator

d-fal commented Aug 19, 2021

Sounds good, will go-pg users be invited to use buntype?

@vmihailenco
Copy link
Member Author

They are definitely welcome (just like everyone else). Is there anything specific we need to do to better accommodate them?

@d-fal
Copy link
Collaborator

d-fal commented Aug 19, 2021

Since the ultimate fate of go-pg is to be replaced by bun, I think this is a good start to let its users know if they are looking for new features, there is a bun out there.

@vmihailenco
Copy link
Member Author

Yes, I will add big fat banner to go-pg once we release Bun v1.0 which should happen this month. The only blocking issue is #59 and docs polishing.

@d-fal
Copy link
Collaborator

d-fal commented Aug 19, 2021

I was testing the package with bigint and I found that when I want to load fixtures from yaml file, I got unmarshall error. Should we equip the extra types with marshall/unmarshallers as well?

@vmihailenco
Copy link
Member Author

@d-fal yes, probably, that is main advantage of having these types in the main repo, But perhaps we need a scanner func instead - I am not sure. Perhaps I will know more after #59 is closed.

@vmihailenco vmihailenco self-assigned this Oct 24, 2021
@vmihailenco vmihailenco added the enhancement New feature or request label Oct 24, 2021
Copy link

github-actions bot commented Nov 7, 2024

This issue has been automatically marked as stale because it has not had activity in the last 30 days. If there is no update within the next 7 days, this issue will be closed.

@github-actions github-actions bot added the stale label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

No branches or pull requests

2 participants