Skip to content
This repository has been archived by the owner on Oct 1, 2023. It is now read-only.

Bower.json limits angularLoad to no greater then 1.5.x #43

Open
mr-White opened this issue Jul 13, 2017 · 1 comment
Open

Bower.json limits angularLoad to no greater then 1.5.x #43

mr-White opened this issue Jul 13, 2017 · 1 comment

Comments

@mr-White
Copy link

I ran into an issue during a bower install that had some conflicts. I don't believe it's necessary to limit this module to less then 1.6.0

I tested the angularLoad service code in my current AngularJS 1.6.5 project by creating a new service and copying/pasting your code into it. The loadScript functions works wonderfully in 1.6.5

I'm assuming, you can remove the restriction from the bower.json file, as this module and service should function normally on 1.6.x

Maybe I'm wrong? I haven't tested any of the other functions (all I needed was the loadScript).

The code in question:

"dependencies": {
   "angular": ">=1.0.0 <1.6.0"
},

Change too:

"dependencies": {
   "angular": ">=1.0.0"
},

I can submit a PR if you wish.... just let me know

@phw
Copy link

phw commented Jul 17, 2017

Agreed, seems to work for me with Angular 1.6

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants