From 3ac17f9a962fe9597c38f34d926d6d65922a41a9 Mon Sep 17 00:00:00 2001 From: SuperKogito Date: Sat, 17 Apr 2021 22:34:24 +0200 Subject: [PATCH 1/7] use hidden variable for codacy token in travis script --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index d82702a..c3586b8 100644 --- a/.travis.yml +++ b/.travis.yml @@ -33,5 +33,5 @@ after_success: - codecov - coveralls - coverage xml - - export CODACY_PROJECT_TOKEN=d4795dc96ed74f7c8415a2e8c3c42467 + - export CODACY_PROJECT_TOKEN=$CodacyToken - python-codacy-coverage -r coverage.xml From a1163df3741ad8084b5886ecf0e0d1f8669650a0 Mon Sep 17 00:00:00 2001 From: SuperKogito Date: Sat, 17 Apr 2021 23:14:14 +0200 Subject: [PATCH 2/7] add {} to variable name --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index c3586b8..a53d9e5 100644 --- a/.travis.yml +++ b/.travis.yml @@ -33,5 +33,5 @@ after_success: - codecov - coveralls - coverage xml - - export CODACY_PROJECT_TOKEN=$CodacyToken + - export CODACY_PROJECT_TOKEN=${CodacyToken} - python-codacy-coverage -r coverage.xml From 41454fe97c6b29bf96061c90d1b00872a04fa6ea Mon Sep 17 00:00:00 2001 From: Ayoub Malek Date: Sat, 17 Apr 2021 23:24:59 +0200 Subject: [PATCH 3/7] use Github secrets to hide token --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index a53d9e5..edf12ce 100644 --- a/.travis.yml +++ b/.travis.yml @@ -33,5 +33,5 @@ after_success: - codecov - coveralls - coverage xml - - export CODACY_PROJECT_TOKEN=${CodacyToken} + - export CODACY_PROJECT_TOKEN=${{ secrets.CODACY_PROJECT_TOKEN }} - python-codacy-coverage -r coverage.xml From 54e63fdbea6f4b537edbbeb54006fccc55d21675 Mon Sep 17 00:00:00 2001 From: Ayoub Malek Date: Sat, 17 Apr 2021 23:33:03 +0200 Subject: [PATCH 4/7] use one pair of {} reference: https://travis-ci.community/t/help-environment-variable-bad-substitution-error/1741 --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index edf12ce..07b583d 100644 --- a/.travis.yml +++ b/.travis.yml @@ -33,5 +33,5 @@ after_success: - codecov - coveralls - coverage xml - - export CODACY_PROJECT_TOKEN=${{ secrets.CODACY_PROJECT_TOKEN }} + - export CODACY_PROJECT_TOKEN=${ secrets.CODACY_PROJECT_TOKEN } - python-codacy-coverage -r coverage.xml From 42001ae26621b33d3b29953c5120fb3e6bf7796d Mon Sep 17 00:00:00 2001 From: Ayoub Malek Date: Sat, 17 Apr 2021 23:42:13 +0200 Subject: [PATCH 5/7] try a different syntax with env section --- .travis.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 07b583d..5ea14ab 100644 --- a/.travis.yml +++ b/.travis.yml @@ -8,6 +8,9 @@ python: - "3.6" - "3.7" +env: + - CODACY_PROJECT_TOKEN = CodacyToken + cache: - pip @@ -33,5 +36,5 @@ after_success: - codecov - coveralls - coverage xml - - export CODACY_PROJECT_TOKEN=${ secrets.CODACY_PROJECT_TOKEN } + - export CODACY_PROJECT_TOKEN=CodacyToken - python-codacy-coverage -r coverage.xml From 3008b72362028d5453c68d689422a020798f0594 Mon Sep 17 00:00:00 2001 From: Ayoub Malek Date: Sat, 17 Apr 2021 23:56:17 +0200 Subject: [PATCH 6/7] use ${var} --- .travis.yml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.travis.yml b/.travis.yml index 5ea14ab..4352263 100644 --- a/.travis.yml +++ b/.travis.yml @@ -7,9 +7,6 @@ python: - "3.5" - "3.6" - "3.7" - -env: - - CODACY_PROJECT_TOKEN = CodacyToken cache: - pip @@ -36,5 +33,5 @@ after_success: - codecov - coveralls - coverage xml - - export CODACY_PROJECT_TOKEN=CodacyToken + - export CODACY_PROJECT_TOKEN=${CodacyToken} - python-codacy-coverage -r coverage.xml From ec529efe3e50055dea485bfd02131c6254765159 Mon Sep 17 00:00:00 2001 From: Ayoub Malek Date: Sun, 18 Apr 2021 00:11:37 +0200 Subject: [PATCH 7/7] add env section with var definition --- .travis.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.travis.yml b/.travis.yml index 4352263..d9e9551 100644 --- a/.travis.yml +++ b/.travis.yml @@ -7,6 +7,9 @@ python: - "3.5" - "3.6" - "3.7" + +env: + - CODACY_PROJECT_TOKEN=${CodacyToken} cache: - pip