From 2c828c13922911111ec206468aa7cb34dbb394ac Mon Sep 17 00:00:00 2001 From: ayman abdelghany Date: Sat, 26 Mar 2016 14:01:19 +0200 Subject: [PATCH 01/16] Resources should be closed --- .../edu/isi/karma/cleaning/features/RecordClassifier.java | 8 +++----- .../karma/controller/update/CSVImportPreviewUpdate.java | 4 +++- .../src/main/java/edu/isi/karma/util/OracleUtil.java | 2 ++ 3 files changed, 8 insertions(+), 6 deletions(-) diff --git a/karma-cleaning/src/main/java/edu/isi/karma/cleaning/features/RecordClassifier.java b/karma-cleaning/src/main/java/edu/isi/karma/cleaning/features/RecordClassifier.java index 62d65bd7c..69e71d095 100644 --- a/karma-cleaning/src/main/java/edu/isi/karma/cleaning/features/RecordClassifier.java +++ b/karma-cleaning/src/main/java/edu/isi/karma/cleaning/features/RecordClassifier.java @@ -496,9 +496,9 @@ public void testOnFile() { String[] vocbs = { "x","DIGITs" }; String fpath1 = "/Users/bowu/Research/testdata/tmp/data.txt"; String fpath2 = "/Users/bowu/Research/testdata/tmp/labels.txt"; - try { - BufferedReader br1 = new BufferedReader(new FileReader(fpath1)); - BufferedReader br2 = new BufferedReader(new FileReader(fpath2)); + try (BufferedReader br1 = new BufferedReader(new FileReader(fpath1)); + BufferedReader br2 = new BufferedReader(new FileReader(fpath2))) { + String line = ""; ArrayList data = new ArrayList(); ArrayList labels = new ArrayList(); @@ -530,8 +530,6 @@ public void testOnFile() { getLabel(test[i]))); } selfVerify(); - br1.close(); - br2.close(); } catch (Exception ex) { ex.printStackTrace(); } diff --git a/karma-commands/commands-import/import-csv/src/main/java/edu/isi/karma/controller/update/CSVImportPreviewUpdate.java b/karma-commands/commands-import/import-csv/src/main/java/edu/isi/karma/controller/update/CSVImportPreviewUpdate.java index d40997c89..922274689 100644 --- a/karma-commands/commands-import/import-csv/src/main/java/edu/isi/karma/controller/update/CSVImportPreviewUpdate.java +++ b/karma-commands/commands-import/import-csv/src/main/java/edu/isi/karma/controller/update/CSVImportPreviewUpdate.java @@ -92,7 +92,7 @@ public CSVImportPreviewUpdate(char delimiterChar, char quoteChar, @Override public void generateJson(String prefix, PrintWriter pw, VWorkspace vWorkspace) { - Scanner scanner; + Scanner scanner = null; int rowCount = 0; int previewRowCounter = 0; @@ -181,6 +181,8 @@ public void generateJson(String prefix, PrintWriter pw, logger.error("Error occured while reading the file!", e); } catch (JSONException e) { logger.error("Error occured while writing to JSON", e); + } finally { + scanner.close(); } } diff --git a/karma-jdbc/src/main/java/edu/isi/karma/util/OracleUtil.java b/karma-jdbc/src/main/java/edu/isi/karma/util/OracleUtil.java index b447ade66..3efe6c818 100644 --- a/karma-jdbc/src/main/java/edu/isi/karma/util/OracleUtil.java +++ b/karma-jdbc/src/main/java/edu/isi/karma/util/OracleUtil.java @@ -52,6 +52,8 @@ public ArrayList getListOfTables(Connection conn) String tableName = rs.getString(1); tableNames.add(tableName); } + stmt.close(); + rs.close(); Collections.sort(tableNames); return tableNames; } From cd09b4da7fbc6d1b5e4361dea33a0f00de99a745 Mon Sep 17 00:00:00 2001 From: ayman abdelghany Date: Sat, 26 Mar 2016 14:06:55 +0200 Subject: [PATCH 02/16] equals(Object obj)" and "hashCode()" should be overridden in pairs --- .../update/AlignmentSVGVisualizationUpdate.java | 8 ++++++++ .../controller/update/AllWorksheetHeadersUpdate.java | 6 ++++++ .../controller/update/RegenerateWorksheetUpdate.java | 4 ++++ .../karma/controller/update/WorksheetCleaningUpdate.java | 8 ++++++++ .../karma/controller/update/WorksheetDeleteUpdate.java | 6 +++++- .../update/WorksheetSuperSelectionListUpdate.java | 4 ++++ 6 files changed, 35 insertions(+), 1 deletion(-) diff --git a/karma-commands/commands-common/src/main/java/edu/isi/karma/controller/update/AlignmentSVGVisualizationUpdate.java b/karma-commands/commands-common/src/main/java/edu/isi/karma/controller/update/AlignmentSVGVisualizationUpdate.java index b2c723cfa..8cab96741 100644 --- a/karma-commands/commands-common/src/main/java/edu/isi/karma/controller/update/AlignmentSVGVisualizationUpdate.java +++ b/karma-commands/commands-common/src/main/java/edu/isi/karma/controller/update/AlignmentSVGVisualizationUpdate.java @@ -114,6 +114,14 @@ public boolean equals(Object o) { return false; } + @Override + public int hashCode() { + int result = this.worksheetId != null ? this.worksheetId.hashCode() : 0; + result = 31 * result + (this.alignmentGraph != null ? this.alignmentGraph.hashCode() : 0); + result = 31 * result + (this.alignment != null ? this.alignment.hashCode() : 0); + return result; + } + @Override public void generateJson(String prefix, PrintWriter pw, VWorkspace vWorkspace) { diff --git a/karma-commands/commands-common/src/main/java/edu/isi/karma/controller/update/AllWorksheetHeadersUpdate.java b/karma-commands/commands-common/src/main/java/edu/isi/karma/controller/update/AllWorksheetHeadersUpdate.java index ef710c98d..1f43fe392 100644 --- a/karma-commands/commands-common/src/main/java/edu/isi/karma/controller/update/AllWorksheetHeadersUpdate.java +++ b/karma-commands/commands-common/src/main/java/edu/isi/karma/controller/update/AllWorksheetHeadersUpdate.java @@ -96,4 +96,10 @@ public boolean equals(Object o) { return false; } + @Override + public int hashCode() { + int result = this.worksheetId != null ? this.worksheetId.hashCode() : 0; + result = 31 * result + (this.deleteAfterGenerate ? 1 : 0); + return result; + } } diff --git a/karma-commands/commands-common/src/main/java/edu/isi/karma/controller/update/RegenerateWorksheetUpdate.java b/karma-commands/commands-common/src/main/java/edu/isi/karma/controller/update/RegenerateWorksheetUpdate.java index b5cce0de7..a2d0ab2bc 100644 --- a/karma-commands/commands-common/src/main/java/edu/isi/karma/controller/update/RegenerateWorksheetUpdate.java +++ b/karma-commands/commands-common/src/main/java/edu/isi/karma/controller/update/RegenerateWorksheetUpdate.java @@ -70,4 +70,8 @@ public boolean equals(Object o) { return false; } + @Override + public int hashCode() { + return this.worksheetId != null ? this.worksheetId.hashCode() : 0; + } } diff --git a/karma-commands/commands-common/src/main/java/edu/isi/karma/controller/update/WorksheetCleaningUpdate.java b/karma-commands/commands-common/src/main/java/edu/isi/karma/controller/update/WorksheetCleaningUpdate.java index 63f58a5ed..0c3058ac0 100644 --- a/karma-commands/commands-common/src/main/java/edu/isi/karma/controller/update/WorksheetCleaningUpdate.java +++ b/karma-commands/commands-common/src/main/java/edu/isi/karma/controller/update/WorksheetCleaningUpdate.java @@ -226,4 +226,12 @@ public boolean equals(Object o) { } return false; } + + @Override + public int hashCode() { + int result = this.worksheetId != null ? this.worksheetId.hashCode() : 0; + result = 31 * result + (this.forceUpdates ? 1 : 0); + result = 31 * result + (this.selection != null ? this.selection.hashCode() : 0); + return result; + } } diff --git a/karma-commands/commands-common/src/main/java/edu/isi/karma/controller/update/WorksheetDeleteUpdate.java b/karma-commands/commands-common/src/main/java/edu/isi/karma/controller/update/WorksheetDeleteUpdate.java index 6bc4b6c9a..fd4a74ae0 100644 --- a/karma-commands/commands-common/src/main/java/edu/isi/karma/controller/update/WorksheetDeleteUpdate.java +++ b/karma-commands/commands-common/src/main/java/edu/isi/karma/controller/update/WorksheetDeleteUpdate.java @@ -52,5 +52,9 @@ public boolean equals(Object o) { } return false; } - + + @Override + public int hashCode() { + return this.worksheetId != null ? this.worksheetId.hashCode() : 0; + } } diff --git a/karma-commands/commands-common/src/main/java/edu/isi/karma/controller/update/WorksheetSuperSelectionListUpdate.java b/karma-commands/commands-common/src/main/java/edu/isi/karma/controller/update/WorksheetSuperSelectionListUpdate.java index 3688f38a1..b1855f7f1 100644 --- a/karma-commands/commands-common/src/main/java/edu/isi/karma/controller/update/WorksheetSuperSelectionListUpdate.java +++ b/karma-commands/commands-common/src/main/java/edu/isi/karma/controller/update/WorksheetSuperSelectionListUpdate.java @@ -52,4 +52,8 @@ public boolean equals(Object o) { return false; } + @Override + public int hashCode() { + return this.worksheetId != null ? this.worksheetId.hashCode() : 0; + } } From a821111de52b122c644ffbbfeaf29d9d0abc838c Mon Sep 17 00:00:00 2001 From: ayman abdelghany Date: Sat, 26 Mar 2016 14:29:05 +0200 Subject: [PATCH 03/16] Equals method should not assume anything about the type of its argument --- .../edu/isi/karma/rep/cleaning/RamblerTransformation.java | 4 ++++ .../isi/karma/geospatial/WorksheetToFeatureCollection.java | 2 +- .../src/main/java/edu/isi/karma/rep/alignment/ColumnNode.java | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/karma-cleaning/src/main/java/edu/isi/karma/rep/cleaning/RamblerTransformation.java b/karma-cleaning/src/main/java/edu/isi/karma/rep/cleaning/RamblerTransformation.java index 31e11d5b7..d67fa6fed 100644 --- a/karma-cleaning/src/main/java/edu/isi/karma/rep/cleaning/RamblerTransformation.java +++ b/karma-cleaning/src/main/java/edu/isi/karma/rep/cleaning/RamblerTransformation.java @@ -51,6 +51,10 @@ public int hashCode() } public boolean equals(Object other) { + if (other == null) { + return false; + } + RamblerTransformation e = (RamblerTransformation)other; if(e.signature.compareTo(this.signature)==0) { diff --git a/karma-commands/commands-import/import-spatial/src/main/java/edu/isi/karma/geospatial/WorksheetToFeatureCollection.java b/karma-commands/commands-import/import-spatial/src/main/java/edu/isi/karma/geospatial/WorksheetToFeatureCollection.java index 69688a1ce..b15b45e12 100644 --- a/karma-commands/commands-import/import-spatial/src/main/java/edu/isi/karma/geospatial/WorksheetToFeatureCollection.java +++ b/karma-commands/commands-import/import-spatial/src/main/java/edu/isi/karma/geospatial/WorksheetToFeatureCollection.java @@ -523,7 +523,7 @@ public File saveShapefile(List features, if(crs2==null) continue; - if(!crs.equals(crs2)) { + if(crs != null && !crs.equals(crs2)) { remainingFeatures.add(feature); features.remove(i); i--; diff --git a/karma-common/src/main/java/edu/isi/karma/rep/alignment/ColumnNode.java b/karma-common/src/main/java/edu/isi/karma/rep/alignment/ColumnNode.java index 971ef19e8..af4de9db9 100644 --- a/karma-common/src/main/java/edu/isi/karma/rep/alignment/ColumnNode.java +++ b/karma-common/src/main/java/edu/isi/karma/rep/alignment/ColumnNode.java @@ -157,7 +157,7 @@ public void unassignUserType(SemanticType semanticType) { } } } - if (tobeDeletedIndex != -1) { + if (tobeDeletedIndex != -1 && userSemanticTypes != null) { userSemanticTypes.remove(tobeDeletedIndex); } if (userSemanticTypes == null || userSemanticTypes.isEmpty()) From cef35dcb1a5042d1e8fabbbd61cb731a78c64454 Mon Sep 17 00:00:00 2001 From: ayman abdelghany Date: Sat, 26 Mar 2016 17:06:59 +0200 Subject: [PATCH 04/16] The operator ("<>") should be used. --- .../cleaning/Correctness/FormatFunc.java | 10 +- .../cleaning/Correctness/OutlierDetector.java | 2 +- .../cleaning/Correctness/Recommander.java | 4 +- .../karma/cleaning/Correctness/ViewFunc.java | 20 +-- .../isi/karma/cleaning/DataPreProcessor.java | 14 +- .../isi/karma/cleaning/ExampleCluster.java | 62 +++---- .../isi/karma/cleaning/ExampleSelection.java | 20 +-- .../edu/isi/karma/cleaning/ExampleTraces.java | 12 +- .../cleaning/GradientDecendOptimizer.java | 24 +-- .../edu/isi/karma/cleaning/LinearSolver.java | 2 +- .../java/edu/isi/karma/cleaning/Messager.java | 6 +- .../java/edu/isi/karma/cleaning/MyLogger.java | 2 +- .../isi/karma/cleaning/OptimizePartition.java | 22 +-- .../edu/isi/karma/cleaning/ParseTreeNode.java | 2 +- .../edu/isi/karma/cleaning/Partition.java | 16 +- .../java/edu/isi/karma/cleaning/Patcher.java | 8 +- .../java/edu/isi/karma/cleaning/Position.java | 36 ++-- .../edu/isi/karma/cleaning/PositionSet.java | 4 +- .../edu/isi/karma/cleaning/ProgSynthesis.java | 28 ++-- .../java/edu/isi/karma/cleaning/Program.java | 6 +- .../isi/karma/cleaning/ProgramAdaptator.java | 152 ++++++++--------- .../edu/isi/karma/cleaning/ProgramParser.java | 2 +- .../edu/isi/karma/cleaning/ProgramRule.java | 4 +- .../cleaning/QuestionableRecord/Feature1.java | 2 +- .../cleaning/QuestionableRecord/Feature2.java | 2 +- .../cleaning/QuestionableRecord/Feature4.java | 4 +- .../QuestionableRecord/FeatureVector.java | 12 +- .../QuestionableRecord/OutlierDetector.java | 10 +- .../isi/karma/cleaning/Research/ANode.java | 10 +- .../cleaning/Research/ClassifierRefiner.java | 6 +- .../Research/ConstrainedAlignment.java | 4 +- .../cleaning/Research/DataCollection.java | 6 +- .../karma/cleaning/Research/MultiIndex.java | 6 +- .../Research/MultipleStringAlign.java | 24 +-- .../isi/karma/cleaning/Research/Prober.java | 2 +- .../cleaning/Research/RecordDistiller.java | 30 ++-- .../edu/isi/karma/cleaning/Research/Test.java | 140 ++++++++-------- .../karma/cleaning/Research/TestTools.java | 6 +- .../karma/cleaning/Research/TimerRunner.java | 34 ++-- .../isi/karma/cleaning/Research/Tools.java | 12 +- .../java/edu/isi/karma/cleaning/Ruler.java | 22 +-- .../java/edu/isi/karma/cleaning/Section.java | 16 +- .../java/edu/isi/karma/cleaning/Segment.java | 32 ++-- .../edu/isi/karma/cleaning/SegmentMapper.java | 22 +-- .../java/edu/isi/karma/cleaning/Template.java | 10 +- .../java/edu/isi/karma/cleaning/Traces.java | 122 +++++++------- .../edu/isi/karma/cleaning/UtilTools.java | 26 +-- .../karma/cleaning/features/CntFeature.java | 2 +- .../cleaning/features/Data2Features.java | 6 +- .../karma/cleaning/features/DataRanking.java | 2 +- .../karma/cleaning/features/MovFeature.java | 2 +- .../cleaning/features/RecordClassifier.java | 34 ++-- .../cleaning/features/RecordFeatureSet.java | 12 +- .../cleaning/features/RecordTextFeature.java | 2 +- .../features/RegularityFeatureSet.java | 24 +-- .../cleaning/features/VarianceFeatureSet.java | 2 +- .../InternalTransformationLibrary.java | 2 +- .../cleaning/RamblerTransformationOutput.java | 6 +- .../rep/cleaning/RamblerValueCollection.java | 4 +- .../isi/karma/kr2rml/KR2RMLMappingWriter.java | 2 +- .../command/alignment/AugmentDataCommand.java | 32 ++-- .../FetchR2RMLModelsListCommand.java | 6 +- .../alignment/GetAlternativeLinksCommand.java | 2 +- .../command/alignment/GetClassesCommand.java | 8 +- .../alignment/GetPropertiesCommand.java | 4 +- .../alignment/SetSemanticTypeCommand.java | 2 +- .../alignment/SuggestAutoModelCommand.java | 2 +- .../alignment/SuggestModelCommand.java | 4 +- .../UnassignSemanticTypeCommand.java | 4 +- .../SearchForDataToAugmentCommand.java | 18 +- ...SearchForDataToAugmentIncomingCommand.java | 18 +- .../er/helper/BloomFilterTripleStoreUtil.java | 14 +- .../writer/KR2RMLBloomFilterManager.java | 4 +- .../FetchTransformingDataCommand.java | 8 +- .../GenerateCleaningRulesCommand.java | 30 ++-- .../InvokeCleaningServiceCommand.java | 4 +- .../cleaning/SubmitCleaningCommand.java | 8 +- .../history/CommandHistoryUtil.java | 8 +- .../controller/history/HistoryJSONEditor.java | 4 +- .../AlignmentSVGVisualizationUpdate.java | 6 +- .../update/WorksheetCleaningUpdate.java | 8 +- .../update/CSVImportPreviewUpdate.java | 4 +- .../imp/database/DatabaseTableImport.java | 2 +- .../edu/isi/karma/imp/database/SQLImport.java | 2 +- .../edu/isi/karma/imp/mdb/MDBFileExport.java | 6 +- .../isi/karma/geospatial/FeatureTable.java | 2 +- .../edu/isi/karma/geospatial/LineString.java | 2 +- .../java/edu/isi/karma/geospatial/Point.java | 2 +- .../WorksheetGeospatialContent.java | 20 +-- .../WorksheetToFeatureCollection.java | 30 ++-- .../alignment/GenerateR2RMLModelCommand.java | 2 +- .../command/publish/PublishRDFCommand.java | 4 +- .../worksheet/ExportCSVCommandFactory.java | 4 +- .../command/worksheet/FetchColumnCommand.java | 2 +- .../isi/karma/er/helper/ExportCSVUtil.java | 4 +- .../model/serialization/DataSourceLoader.java | 18 +- .../MutatingPythonTransformationCommand.java | 6 +- .../PythonTransformationCommand.java | 4 +- .../SubmitPythonTransformationCommand.java | 6 +- .../mapping/KR2RMLMappingGenerator.java | 6 +- .../PythonTransformationAsURITokenizer.java | 6 +- .../command/service/InvokeServiceCommand.java | 6 +- .../command/service/PopulateCommand.java | 10 +- .../update/CleaningResultUpdate.java | 4 +- .../command/worksheet/AddColumnCommand.java | 2 +- .../command/worksheet/AddValuesCommand.java | 2 +- .../worksheet/ExtractEntitiesCommand.java | 4 +- .../command/worksheet/FoldCommand.java | 6 +- .../GenerateClusterValuesCommand.java | 2 +- .../command/worksheet/GlueCommand.java | 16 +- .../command/worksheet/GroupByCommand.java | 18 +- .../worksheet/MergeClusterValuesCommand.java | 8 +- .../MultipleValueEditColumnCommand.java | 2 +- ...MultipleValueEditColumnCommandFactory.java | 2 +- .../worksheet/SplitByCommaCommand.java | 6 +- .../worksheet/SplitColumnByDelimiter.java | 6 +- .../command/worksheet/UnfoldCommand.java | 36 ++-- .../selection/ClearSelectionCommand.java | 2 +- .../selection/RefreshSelectionCommand.java | 2 +- .../RefreshSuperSelectionCommand.java | 2 +- .../config/ModelingConfigurationRegistry.java | 2 +- .../karma/config/UIConfigurationRegistry.java | 2 +- .../isi/karma/controller/command/Command.java | 6 +- .../command/selection/MiniSelection.java | 4 +- .../command/selection/Selection.java | 12 +- .../command/selection/SelectionManager.java | 6 +- .../command/selection/SuperSelection.java | 4 +- .../selection/SuperSelectionManager.java | 4 +- .../command/service/ServiceTableUtil.java | 14 +- .../controller/history/CommandHistory.java | 2 +- .../update/SemanticTypesUpdate.java | 4 +- .../controller/update/UpdateContainer.java | 4 +- .../isi/karma/er/helper/CloneTableUtils.java | 2 +- .../isi/karma/er/helper/PythonRepository.java | 12 +- .../er/helper/PythonRepositoryRegistry.java | 2 +- .../karma/er/helper/SPARQLGeneratorUtil.java | 26 +-- .../isi/karma/er/helper/TripleStoreUtil.java | 82 +++++----- .../edu/isi/karma/imp/avro/AvroImport.java | 6 +- .../edu/isi/karma/imp/csv/CSVFileExport.java | 6 +- .../java/edu/isi/karma/imp/csv/CSVImport.java | 6 +- .../isi/karma/imp/json/JsonImportValues.java | 4 +- .../isi/karma/kr2rml/ContextGenerator.java | 6 +- .../kr2rml/KR2RMLWorksheetRDFGenerator.java | 16 +- .../karma/kr2rml/ShortHandURIGenerator.java | 4 +- .../java/edu/isi/karma/kr2rml/SubjectMap.java | 2 +- .../edu/isi/karma/kr2rml/URIFormatter.java | 6 +- .../formatter/KR2RMLColumnNameFormatter.java | 4 +- .../karma/kr2rml/mapping/KR2RMLMapping.java | 4 +- .../KR2RMLMappingAuxillaryInformation.java | 10 +- ...R2RMLMappingColumnNameHNodeTranslator.java | 4 +- .../karma/kr2rml/mapping/R2RMLMapping.java | 4 +- .../WorksheetR2RMLJenaModelParser.java | 8 +- .../ConstantPredicateObjectMappingPlan.java | 2 +- .../planning/DFSTriplesMapGraphDAGifier.java | 16 +- .../planning/PredicateObjectMappingPlan.java | 14 +- .../karma/kr2rml/planning/SubjectMapPlan.java | 4 +- .../isi/karma/kr2rml/planning/TriplesMap.java | 2 +- .../kr2rml/planning/TriplesMapGraph.java | 40 ++--- .../planning/TriplesMapGraphMerger.java | 4 +- .../planning/TriplesMapPlanExecutor.java | 2 +- .../planning/TriplesMapPlanGenerator.java | 14 +- .../kr2rml/planning/TriplesMapWorker.java | 2 +- .../kr2rml/planning/TriplesMapWorkerPlan.java | 6 +- .../ConstantTemplateTermSetPopulatorPlan.java | 4 +- ...oublyAnchoredTemplateTermSetPopulator.java | 4 +- ...namicTemplateTermSetPopulatorStrategy.java | 2 +- ...oizedTemplateTermSetPopulatorStrategy.java | 2 +- .../template/PartiallyPopulatedTermSet.java | 4 +- ...yAnchoredTemplateTermSetPopulatorPlan.java | 18 +- .../kr2rml/template/TemplateTermSet.java | 4 +- .../template/TemplateTermSetPopulator.java | 4 +- .../TemplateTermSetPopulatorPlan.java | 20 +-- .../TemplateTermSetPopulatorWorker.java | 8 +- .../kr2rml/writer/AvroKR2RMLRDFWriter.java | 20 +-- .../kr2rml/writer/JSONKR2RMLRDFWriter.java | 2 +- .../kr2rml/writer/N3KR2RMLRDFWriter.java | 6 +- .../kr2rml/writer/SFKR2RMLRDFWriter.java | 10 +- .../karma/metadata/KarmaMetadataManager.java | 2 +- .../isi/karma/metadata/KarmaUserMetadata.java | 2 +- .../model/serialization/WebServiceLoader.java | 26 +-- .../java/edu/isi/karma/modeling/Uris.java | 2 +- .../karma/modeling/alignment/Alignment.java | 38 ++--- .../modeling/alignment/AlignmentManager.java | 4 +- .../modeling/alignment/GraphBuilder.java | 92 +++++------ .../modeling/alignment/GraphBuilderTopK.java | 24 +-- .../karma/modeling/alignment/GraphPath.java | 4 +- .../modeling/alignment/GraphPreProcess.java | 2 +- .../karma/modeling/alignment/GraphUtil.java | 40 ++--- .../modeling/alignment/GraphVizUtil.java | 2 +- .../modeling/alignment/LinkIdFactory.java | 2 +- .../modeling/alignment/NodeIdFactory.java | 2 +- .../modeling/alignment/SemanticModel.java | 64 ++++---- .../karma/modeling/alignment/SteinerTree.java | 32 ++-- .../modeling/alignment/TreePostProcess.java | 12 +- .../learner/CandidateSteinerSets.java | 14 +- .../modeling/alignment/learner/Coherence.java | 16 +- .../alignment/learner/Confidence.java | 4 +- .../alignment/learner/ModelLearner.java | 30 ++-- .../alignment/learner/ModelLearner_Old.java | 44 ++--- .../alignment/learner/ModelLearningGraph.java | 4 +- .../learner/ModelLearningGraphCompact.java | 46 +++--- .../ModelLearningGraphCompact_Old.java | 38 ++--- .../learner/ModelLearningGraphSparse.java | 2 +- .../alignment/learner/ModelReader.java | 2 +- .../alignment/learner/SteinerNodes.java | 12 +- .../karma/modeling/ontology/AutoOntology.java | 2 +- .../modeling/ontology/OntologyCache.java | 154 +++++++++--------- .../modeling/ontology/OntologyHandler.java | 30 ++-- .../modeling/ontology/OntologyManager.java | 40 ++--- .../SemanticTypeColumnModel.java | 4 +- .../semantictypes/SemanticTypeUtil.java | 24 +-- .../steiner/topk/ApprSteinerTree.java | 20 +-- .../steiner/topk/BANKSfromMM_Old.java | 76 ++++----- .../steiner/topk/CustomizedBANKS.java | 64 ++++---- .../karma/modeling/steiner/topk/Graph.java | 10 +- .../modeling/steiner/topk/LoosePath.java | 4 +- .../modeling/steiner/topk/ModelCoherence.java | 6 +- .../modeling/steiner/topk/ResultGraph.java | 2 +- .../modeling/steiner/topk/SteinerNode.java | 10 +- .../modeling/steiner/topk/SteinerSubTree.java | 4 +- .../steiner/topk/TopKSteinertrees.java | 46 +++--- .../java/edu/isi/karma/rdf/RdfGenerator.java | 4 +- .../edu/isi/karma/rep/ColumnMetadata.java | 14 +- .../main/java/edu/isi/karma/rep/HNode.java | 6 +- .../java/edu/isi/karma/rep/HNodePath.java | 2 +- .../main/java/edu/isi/karma/rep/HTable.java | 10 +- .../edu/isi/karma/rep/HashValueManager.java | 10 +- .../java/edu/isi/karma/rep/RepFactory.java | 12 +- .../src/main/java/edu/isi/karma/rep/Row.java | 2 +- .../main/java/edu/isi/karma/rep/Table.java | 6 +- .../java/edu/isi/karma/rep/Workspace.java | 4 +- .../edu/isi/karma/rep/WorkspaceManager.java | 2 +- .../isi/karma/rep/alignment/ColumnNode.java | 8 +- .../isi/karma/rep/alignment/DisplayModel.java | 42 ++--- .../isi/karma/rep/alignment/LabeledLink.java | 6 +- .../edu/isi/karma/rep/alignment/Node.java | 4 +- .../karma/rep/alignment/SemanticTypes.java | 4 +- .../karma/rep/metadata/SourceInformation.java | 2 +- .../java/edu/isi/karma/rep/metadata/Tag.java | 2 +- .../isi/karma/rep/metadata/TagsContainer.java | 2 +- .../rep/metadata/WorksheetProperties.java | 2 +- .../java/edu/isi/karma/rep/model/Model.java | 30 ++-- .../edu/isi/karma/rep/sources/DataSource.java | 28 ++-- .../edu/isi/karma/rep/sources/Invocation.java | 6 +- .../karma/rep/sources/InvocationManager.java | 24 +-- .../edu/isi/karma/rep/sources/Request.java | 2 +- .../edu/isi/karma/rep/sources/Response.java | 2 +- .../java/edu/isi/karma/rep/sources/Table.java | 46 +++--- .../edu/isi/karma/rep/sources/URLManager.java | 18 +- .../edu/isi/karma/rep/sources/WebService.java | 50 +++--- .../isi/karma/service/json/ArrayValue.java | 2 +- .../edu/isi/karma/service/json/Element.java | 4 +- .../isi/karma/service/json/JsonManager.java | 12 +- .../java/edu/isi/karma/util/HTTPUtil.java | 2 +- .../main/java/edu/isi/karma/util/Util.java | 10 +- .../main/java/edu/isi/karma/view/VHNode.java | 2 +- .../java/edu/isi/karma/view/VWorksheet.java | 2 +- .../isi/karma/view/VWorkspaceRegistry.java | 2 +- .../java/edu/isi/karma/view/ViewFactory.java | 4 +- .../karma/webserver/ExecutionController.java | 2 +- .../karma/webserver/WorkspaceRegistry.java | 2 +- .../karma/rdf/DatabaseTableRDFGenerator.java | 2 +- .../edu/isi/karma/util/AbstractJDBCUtil.java | 10 +- .../java/edu/isi/karma/util/MySQLUtil.java | 2 +- .../java/edu/isi/karma/util/OracleUtil.java | 2 +- .../java/edu/isi/karma/util/PostGISUtil.java | 2 +- .../edu/isi/karma/util/SQLServerUtil.java | 6 +- .../java/edu/isi/karma/util/SybaseUtil.java | 2 +- .../com/github/jsonldjava/core/Context.java | 16 +- .../com/github/jsonldjava/core/JsonLdApi.java | 114 ++++++------- .../jsonldjava/core/JsonLdProcessor.java | 18 +- .../github/jsonldjava/core/JsonLdUtils.java | 22 +-- .../jsonldjava/core/NormalizeUtils.java | 36 ++-- .../github/jsonldjava/core/RDFDataset.java | 8 +- .../jsonldjava/core/RDFDatasetUtils.java | 8 +- .../github/jsonldjava/core/UniqueNamer.java | 2 +- .../jsonldjava/impl/TurtleRDFParser.java | 4 +- .../jsonldjava/impl/TurtleTripleCallback.java | 26 +-- .../jsonldjava/utils/JarCacheStorage.java | 8 +- .../github/jsonldjava/utils/JsonLdUrl.java | 8 +- .../java/com/github/jsonldjava/utils/Obj.java | 2 +- .../isi/karma/mapreduce/driver/N3Reducer.java | 2 +- .../mapreduce/driver/N3ToJSONReducer.java | 2 +- .../mapreduce/function/CollectJSONObject.java | 2 +- .../function/CreateJSONFromSequenceFile.java | 4 +- .../function/CreateSequenceFile.java | 4 +- .../karma/mapreduce/function/MergeJSON.java | 6 +- .../function/SplitAndCleanJSONArray.java | 4 +- .../inputformat/AvroBatchRecordReader.java | 2 +- .../inputformat/CSVBatchRecordReader.java | 2 +- .../SequenceFileAsJSONRecordBatchReader.java | 4 +- .../tripleparser/Neo4jCSVGenerator.java | 6 +- .../mapreduce/tripleparser/TripleMapper.java | 2 +- .../mapreduce/driver/TestJSONMapReduce.java | 6 +- .../driver/TestJSONMapReduceMultiRoots.java | 2 +- .../mapreduce/driver/TestN3MapReduce.java | 16 +- .../mapreduce/driver/TestRDFMapReduce.java | 12 +- .../isi/karma/rdf/GenericRDFGenerator.java | 8 +- .../isi/karma/rdf/OfflineRdfGenerator.java | 14 +- .../isi/karma/rdf/RDFGeneratorRequest.java | 8 +- .../rdf/bloom/AddSameAsToBloomFilters.java | 6 +- .../rdf/bloom/CombineBloomFiltersFromRDF.java | 8 +- .../isi/karma/rdf/TestAvroRDFGenerator.java | 16 +- .../karma/rdf/TestJSONDagRDFGenerator.java | 2 +- .../edu/isi/karma/rdf/TestRdfGenerator.java | 6 +- .../java/edu/isi/karma/rdf/TestSelection.java | 6 +- .../isi/karma/spark/JSONReducerDriver.java | 2 +- .../karma/storm/bolt/KarmaReducerBolt.java | 2 +- .../isi/karma/storm/function/JSONToMerge.java | 4 +- .../karma/storm/TestBasicKarmaTopology.java | 4 +- .../semantictypes/evaluation/EvaluateMRR.java | 8 +- .../karma/semantictypes/numeric/KSTest.java | 2 +- .../typinghandler/HybridSTModelHandler.java | 12 +- .../LuceneBasedSTModelHandler.java | 4 +- .../java/edu/isi/karma/imp/excel/ToCSV.java | 8 +- .../edu/isi/karma/kr2rml/ErrorReport.java | 2 +- .../webserver/ContextParametersRegistry.java | 2 +- .../webserver/ServletContextParameterMap.java | 2 +- .../webserver/WorkspaceKarmaHomeRegistry.java | 2 +- .../es/ElasticSearchPublishServlet.java | 2 +- .../linkedapi/server/PostRequestManager.java | 8 +- .../edu/isi/karma/webserver/ServerStart.java | 2 +- 322 files changed, 2019 insertions(+), 2019 deletions(-) diff --git a/karma-cleaning/src/main/java/edu/isi/karma/cleaning/Correctness/FormatFunc.java b/karma-cleaning/src/main/java/edu/isi/karma/cleaning/Correctness/FormatFunc.java index d84edf5d4..c52d2ced8 100644 --- a/karma-cleaning/src/main/java/edu/isi/karma/cleaning/Correctness/FormatFunc.java +++ b/karma-cleaning/src/main/java/edu/isi/karma/cleaning/Correctness/FormatFunc.java @@ -18,8 +18,8 @@ public class FormatFunc implements VerificationFunc { private int funid = 1; - private HashMap cmeans = new HashMap(); - private HashMap mean_var = new HashMap(); + private HashMap cmeans = new HashMap<>(); + private HashMap mean_var = new HashMap<>(); private double[] dmetric= null; public FormatFunc(ArrayList records, double[] dmetric) { @@ -31,7 +31,7 @@ public FormatFunc(ArrayList records, double[] dmetric) //identify the mean vector of each cluster private void getMeanandDists(ArrayList records, double[] dmetric) { - HashMap> tmp = new HashMap>(); + HashMap> tmp = new HashMap<>(); for(TransRecord rec:records) { if(tmp.containsKey(rec.label)) @@ -40,7 +40,7 @@ private void getMeanandDists(ArrayList records, double[] dmetric) } else { - ArrayList x = new ArrayList(); + ArrayList x = new ArrayList<>(); x.add(rec); tmp.put(rec.label, x); } @@ -51,7 +51,7 @@ private void getMeanandDists(ArrayList records, double[] dmetric) ArrayList tdata = tmp.get(key); if(tdata.size() > 0 || tdata.get(0).features.length > 0) { - ArrayList tcl = new ArrayList(); + ArrayList tcl = new ArrayList<>(); for(int i =0; i< tdata.size(); i++) { tcl.add(tdata.get(i).features); diff --git a/karma-cleaning/src/main/java/edu/isi/karma/cleaning/Correctness/OutlierDetector.java b/karma-cleaning/src/main/java/edu/isi/karma/cleaning/Correctness/OutlierDetector.java index 43af4e9b9..26d96421a 100644 --- a/karma-cleaning/src/main/java/edu/isi/karma/cleaning/Correctness/OutlierDetector.java +++ b/karma-cleaning/src/main/java/edu/isi/karma/cleaning/Correctness/OutlierDetector.java @@ -33,7 +33,7 @@ public static void main(String[] args) OutlierDetector outDet = new OutlierDetector(); String[] dat = {"A", "AA","B", "BB"}; String[] tst = {"B", "b", "AAAAAAAAAAAA","."}; - ArrayList data = new ArrayList(Arrays.asList(dat)); + ArrayList data = new ArrayList<>(Arrays.asList(dat)); outDet.train(data); for(String l:tst) { diff --git a/karma-cleaning/src/main/java/edu/isi/karma/cleaning/Correctness/Recommander.java b/karma-cleaning/src/main/java/edu/isi/karma/cleaning/Correctness/Recommander.java index 3c213597b..503370056 100644 --- a/karma-cleaning/src/main/java/edu/isi/karma/cleaning/Correctness/Recommander.java +++ b/karma-cleaning/src/main/java/edu/isi/karma/cleaning/Correctness/Recommander.java @@ -15,12 +15,12 @@ public Recommander() // public ArrayList getOutliers() { - ArrayList res = new ArrayList(); + ArrayList res = new ArrayList<>(); return res; } public ArrayList getBoundaryPoints() { - ArrayList res = new ArrayList(); + ArrayList res = new ArrayList<>(); return res; } } diff --git a/karma-cleaning/src/main/java/edu/isi/karma/cleaning/Correctness/ViewFunc.java b/karma-cleaning/src/main/java/edu/isi/karma/cleaning/Correctness/ViewFunc.java index a5c12c214..3a1de25bc 100644 --- a/karma-cleaning/src/main/java/edu/isi/karma/cleaning/Correctness/ViewFunc.java +++ b/karma-cleaning/src/main/java/edu/isi/karma/cleaning/Correctness/ViewFunc.java @@ -14,7 +14,7 @@ import edu.isi.karma.cleaning.Traces; public class ViewFunc implements VerificationFunc { - private HashMap data = new HashMap(); + private HashMap data = new HashMap<>(); private String contextId; public ViewFunc(ArrayList records, ProgSynthesis ps, ProgramRule pr, String contextId) { @@ -28,7 +28,7 @@ public ViewFunc(ArrayList records, ProgSynthesis ps, ProgramRule pr } public HashMap> cluster(ArrayList reds) { - HashMap> res = new HashMap>(); + HashMap> res = new HashMap<>(); for(TransRecord r: reds) { if(res.containsKey(r.label)) @@ -36,7 +36,7 @@ public HashMap> cluster(ArrayList re res.get(r.label).add(r); } else { - ArrayList line = new ArrayList(); + ArrayList line = new ArrayList<>(); line.add(r); res.put(r.label, line); } @@ -69,27 +69,27 @@ public boolean identifyIncorrRecord(ArrayList records, } public void identifyRecord(ArrayList records, Traces trace) { - ArrayList