Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve search for content under different ink! version #181

Closed
wottpal opened this issue Feb 28, 2023 · 1 comment · Fixed by #183
Closed

Improve search for content under different ink! version #181

wottpal opened this issue Feb 28, 2023 · 1 comment · Fixed by #183

Comments

@wottpal
Copy link
Contributor

wottpal commented Feb 28, 2023

Hey there, at the moment (at least for me), the search bar in the upper right returns results for both documented ink! versions (3 & 4). And it doesn't even highlight the version. I find it quite counter-intuitive (esp. for newbies) accidentally switching to an earlier version of the documentation without even noticing.

IMO, it should either highlight the version next to the results or (preferred) search should be only within the currently active version of the documentation.

@cmichi
Copy link
Collaborator

cmichi commented Mar 2, 2023

Oh boi, thanks for reporting this, I never noticed.

I just fixed it, but I'm not super-happy about it. The plugin that we use is just not that mature. I've created this follow-up: #184.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants