feat: squash commit of krummbar/bruno-run-action #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contains the code of krummbar/bruno-run-action. Commit history is squashed into a single commit. If preferred I can also preserve the current history.
The current code reflects the features for bru run cli
v1.26.2
.Let me know when you want to publish this action. I'll archive my source repo then and add a reference to the new repository.
Remark
Versioning
For future development we'll need to decide how to proceed with versioning of this action. Currently the bru cli version is backed into the Dockerfile
1.x
. So it'll use the most recent version of version 1.I'm not sure what the best approach is. I could imagine introducing version branches that pin to specific bru cli versions and use a version tag
v1
that also points to the latest commit.branch/v1.20
branch/v1.26
While the tag
v1
always points to the most recent features. A version branch references then the specified version in the Dockerfile.However this could introduce increased maintenance effort if a patch is required to all those versions.
Alternative approach is to remove the installation step from the Dockerfile and move it to the entrypoint.sh script and use a optional version input argument for the action.
Effectively users would then be able to specify bru cli version when including it in their actions. But all the other action input arguments would need to be replaced with a generic one.
Going down this path effectively makes all the other input arguments obsolete.
This is how the action could look like in workflows
Branch/Version based approach
Provide version as argument
Maybe you have some better ideas how to proceed here. Just wanted to leave my thoughts on that topic.