-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow memo date change Firefox / Safari #3812
Comments
Bump 30/08 Discord question re the issue https://discord.com/channels/1017113925776588902/1045138348165050409/1278800934012719104 |
Actually, on Chrome for Android is not working either |
I can confirm that by editing a memo's date on Safari it will show |
Is this going to to be added in the next release? |
https://github.com/user-attachments/assets/7adc14e0-224e-4b0b-9bf6-36419b39e253 |
For now, I would recommend using the MUI/DateTimePicker to solve this issue. https://mui.com/x/api/date-pickers/date-time-picker/ |
I'll give the MUI implementation a go on the weekend |
Update with cf1be81 |
😍 |
😍 |
Describe the bug
in v0.22.4 the ability to update memo dates was reinstated. This feature works in Edge and Chrome but not Firefox or Safari
For Firefox this is due to needing a specific date string format provided as the
datetime-local
typedinput
value
otherwise the time section of the datetime view is not populated. (Chromium based browsers don't have this issue because you can set the time on their calendar view, but you cant do this in Firefox of Safari)This becomes an issue as Firefox only fires the
change event
needed to update thedate time state
if the complete date and time is set on the inputI dont have access to a Mac to debug and confirm this is the same reason for Safari not working, but a quick test showed Safari sets the date to
undefined
POC to test this behaviour
https://jsfiddle.net/95c2zae1/3/
Date format used when featured worked in v0.22.2
memos/web/src/hooks/useDateTime.ts
Line 9 in e4a09c4
Date format used in v0.22.4
memos/web/src/components/MemoEditor/index.tsx
Line 421 in a948555
I've created a PR that will address fixing the date format
#3783
Steps to reproduce
1 -> Create memo using Firefox/Safari
2 -> Edit memo -> change date
3 -> date does not update on UI
The version of Memos you're using.
v0.22.4
Screenshots or additional context
No response
The text was updated successfully, but these errors were encountered: