Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] Co-constraint and OBX-2 verification #1280

Open
carolinerosin opened this issue Jun 23, 2021 · 2 comments
Open

[REQUEST] Co-constraint and OBX-2 verification #1280

carolinerosin opened this issue Jun 23, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@carolinerosin
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Verification must catch if an OBX-2 value in the co-constraint is not present in the value set associated with OBX-2.
Verification must catch if there is no value in OBX-2 in a co-constraint.

This can happen if the user builds a co-constraint and sets a value for OBX-2, and after that goes to delete the value in the value set or modifies the binding and picks a value set without that value.

Describe the solution you'd like
If there is value for OBX-2 in the co-constraint that does not come from HL70125, I don't think this would break validation, but the user can create a profile that always fails. I think this should be categorized as ERROR. Not sure if the user interface would allow that, but it should be checked because could happen in the XML (if user edits the XML and then uploads to GVT).

If there is no value for OBX-2 (see screenshots below), then this is FATAL

Describe alternatives you've considered
n/a

Additional context
Example
Constraint table (based on initial HL70125) : the user picks "CE" (valid at this point because it is in HL70125)
image

Then user creates a flavor of HL70125 and removes "CE". He assigns that flavor to OBX-2
image
image

The co-constraint table looks like that
image

Verification does not pick anything for the moment (probably because we haven't thought about it yet)

@carolinerosin carolinerosin added the enhancement New feature or request label Jun 23, 2021
@Jungyubw
Copy link
Collaborator

Jungyubw commented Jun 23, 2021

@carolinerosin For verification,

If the value of OBX-2 in Co-Constraint is missing ==> Fatal
If the value of OBX-2 in Co-Constraint is not matched with any value of OBX-2's valueset ==> Error

Am I right?

@carolinerosin
Copy link
Collaborator Author

yes, that is correct. We can ask for confirmation to Rob for the second one, but my approach is that FATAL is something that is broken and cannot be processed by GVT/validation.
in the second case, the validation would work, it is just that the user would create a profile that always fails.

@HossamT HossamT assigned HossamT and unassigned Jungyubw and Abdelghani90 Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants