Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: display bindings in the lower right corner of nix-tree. #49

Open
Icy-Thought opened this issue Dec 10, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@Icy-Thought
Copy link

It's rather complicated to find the menu if you are not aware of its existence. Therefore I propose that we add shortcuts which could hint at the existence of such menu in the lower right corner of nix-tree.

Something similar to gitui's approach could prove to be helpful: (forgive the horrible theming)
image

@utdemir
Copy link
Owner

utdemir commented Dec 10, 2022

I think this is a great idea, we can just sacrifice one line at the bottom and make it much more discoverable. This would also make the current help modal redundant. It also seems pretty easy to implement, so I think this will be my next priority :).

Thanks again :).

@Icy-Thought
Copy link
Author

Glad to help out!
I'll make sure to update this thread if I ever come up with a better idea! :)

@utdemir
Copy link
Owner

utdemir commented Dec 18, 2022

Update: I have a prototype implementation:

Screenshot 2022-12-18 at 11 59 39 PM

However it doesn't look that pretty. I feel like as rest of the application doesn't use the colors and background very prominently, the new menubar is too focused to my liking.

I'll play around with different colours to see if I'll find something that fits the rest of the app better.

@Icy-Thought
Copy link
Author

That looks like a good start!

Also, allowing the user to customize the colorscheme of the menu would be more appropriate in my opinion. People use different colorschemes and having one hard-coded theme is not usually desirable.

Config file could be a .yaml, .conf, .dhall file or whatever filetype you deem appropriate for this minor customization!

@utdemir utdemir added the enhancement New feature or request label Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants