Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Hide a closure from search results #51

Open
RileyApeldoorn opened this issue Jan 6, 2023 · 1 comment
Open

Feature request: Hide a closure from search results #51

RileyApeldoorn opened this issue Jan 6, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@RileyApeldoorn
Copy link

Hey there! I sometimes use nix-tree to solve issues with duplicate Python dependencies, and it can be quite hard to keep track of which specific versions of a dependency I've already checked out (especially if there are many different versions in the closure).

It would be great if there was a keybind to hide/"cross out" the currently selected closure for the remainder of the session (or perhaps until restored through a keybind) so that it or anything it closes over does not show up in search results anymore. That would really help a lot!

@utdemir
Copy link
Owner

utdemir commented Jan 6, 2023

Ooh, this is interesting. Thanks for bringing this up :).

First, here's another issue with a vaguely similar concern that this functionality might also help: #29

Here's what I am thinking right now:

It would be great if there was a keybind to hide/"cross out" the currently selected closure for the remainder of the session

I'd be against hiding things as I feel like it would be too easy to trigger it mistakenly which would cause the program to show "incorrect" results for the rest of the session. But "Crossing out" is interesting. I can see how it would be useful.

I also initially thought it might even be more possible to implement it as a "flag" feature where you could mark things with their dependencies with differently coloured flags. So it would also be possible to have common transitive dependencies showing both of the flags. And we can show the flags everywhere we show a store path (why depends, search etc.).

Both for the "crossing out" and "flags", we'd need to think about a good UX. As:

  • We probably want to show somewhere whether the feature is enabled, and which derivation it is targeted.
  • Likely triggering the shortcut again would toggle it.
  • We should word it in a way that is clear what it is doing.

I'll sleep on it for a bit, but I do think this will be a useful addition. "Marking something alongside with all their transitive deps" seems like a useful thing to be able to do. But I want to think more about it and find other use cases to see if it is generally useful.

@utdemir utdemir added the enhancement New feature or request label Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants