Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package unit tests into CI #2

Open
vyahello opened this issue Oct 2, 2020 · 2 comments
Open

Add package unit tests into CI #2

vyahello opened this issue Oct 2, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@vyahello
Copy link
Member

vyahello commented Oct 2, 2020

Please follow AC for the task.

Basically, it should cover the following logic:

  • Build state: Test the code with static analysis and unit tests on code itself
  • Build state: If first passed then we build a package via python setup.py install
  • Test stage: Then we should verify if the package works, it's version/name/flags etc.
  • Create reusable config parts so those could be used for both stages
@vyahello vyahello self-assigned this Oct 2, 2020
@vyahello vyahello added enhancement New feature or request good first issue Good for newcomers labels Oct 17, 2020
@4lovi4
Copy link

4lovi4 commented Oct 19, 2020

Hi @vyahello may I try a shot to resolve the issue? With naive PR

@vyahello
Copy link
Member Author

Hey @4lovi4, sure go ahead, I appreciate your efforts. I've left a few comments before proceeding with the request, please have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants