Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any ability to redirect / silence output? #628

Closed
vlovich opened this issue Jan 27, 2025 · 4 comments
Closed

Any ability to redirect / silence output? #628

vlovich opened this issue Jan 27, 2025 · 4 comments
Labels
🪄 enhancement additions to the software help wanted rust Pull requests that update Rust code

Comments

@vlovich
Copy link
Contributor

vlovich commented Jan 27, 2025

Would be nice if the logs were sent into the tracing module or at least have the ability to turn off all the stderr logspam. Is there a configuration option I'm missing?

@babichjacob
Copy link
Contributor

llama.cpp is doing that - not this crate. It seems someone attempted to provide configuration for it in #626 earlier today but withdrew it.

@vlovich
Copy link
Contributor Author

vlovich commented Jan 28, 2025

Right that PR is exactly it - it sets up a log callback to intercept the events. Being able to trap that via a custom function / optionally default to sending it to trace instead of stderr is what I'm looking for

@MarcusDunn
Copy link
Contributor

sending to trace seems like a reasonable default for us, even if we do not allow consumers of the lib to set the callback (which is treacherous and unergonomic with FFI)

@MarcusDunn MarcusDunn added rust Pull requests that update Rust code 🪄 enhancement additions to the software help wanted labels Jan 28, 2025
@MarcusDunn
Copy link
Contributor

resolved in #637

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪄 enhancement additions to the software help wanted rust Pull requests that update Rust code
Projects
None yet
Development

No branches or pull requests

3 participants