Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latin 1 char, and uncontrolated exception #40

Open
mal3kith-developer opened this issue Dec 30, 2014 · 0 comments
Open

Latin 1 char, and uncontrolated exception #40

mal3kith-developer opened this issue Dec 30, 2014 · 0 comments

Comments

@mal3kith-developer
Copy link

Hi, first congratulations for this project its so usefull.

Recently i must send sms in spain with iso-8859-1 codificatión, in this country alphabet has uncommon letters like 'ñ', i downlowd your project and made twoice changes, exactly in Alphabet and SMPPSession, I attach my changes FYI:
In Alphabet.java add:
/**

ISO-8859-1, AKA Latin 1 */
ALPHA_LATIN_1((byte)0x03),
After this my SMSC don't back OptionalParameters i have a NullPointerException in smpp session, i fix it with this code (lines ~ 297):
try {
OptionalParameter.Sc_interface_version sc_version = resp.getOptionalParameter(Sc_interface_version.class);
if (sc_version != null) {
logger.info("Other side reports smpp interface version {}", sc_version);
}
} catch(Exception ignore) {}

Probably this was innecessary but i only can attach the DataCoding dc = new GeneralDataCoding((byte)0x03), (from Smpp v3.4, pag. 126 -> 00000011 Latin 1 (ISO-8859-1)), appending new ALPHA_XXXXX. Is there another system to do?

Thanks in advance. BR, Mal3kith

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant