Add dark mode support to website #38
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LouisDISPA
had a problem deploying
to
github-pages
GitHub Actions
Failure
|
this is excellent, thanks! |
|
Looks excellent! I like the implementation with CSS variables too. Any reason to keep this as a draft? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I quickly did a dark mode to the website just for fun and see how complex it would be. This is a very simple implementation only in css. Feel free to close this PR if you don't want this feature or don't like it.
I'm happy to work more on it if you are interested in this feature like:
List of changes:
prefers-color-schememedia queriesScreenshots: