Skip to content
This repository has been archived by the owner on Jun 28, 2020. It is now read-only.

Test Buoy Detection More extensively #17

Open
rkeen9 opened this issue Nov 22, 2019 · 5 comments
Open

Test Buoy Detection More extensively #17

rkeen9 opened this issue Nov 22, 2019 · 5 comments
Assignees

Comments

@rkeen9
Copy link
Contributor

rkeen9 commented Nov 22, 2019

No description provided.

@rkeen9 rkeen9 self-assigned this Nov 22, 2019
@rkeen9
Copy link
Contributor Author

rkeen9 commented Nov 22, 2019

  • Test how far away the buoy can be detected
  • Somehow test it underwater
  • try different lighting conditions

@AntonNiko
Copy link
Contributor

From issue #12 :
Issue pinpointed in BuoyDetector.cpp line 20 (hash 726cc87). Two bugs were discovered:

  1. No default value for buoy_type provided to constructor, no error handling
  2. OpenCV complains that parameter detector.buoy_img is not of type CV_8U. Conversions between types is being worked on

@AntonNiko
Copy link
Contributor

Linking greyscale_img_detection. Since it has been found that cv::imread only returns null data when reading with the cv::IMREAD_GRAYSCALE flag, error handling is placed to handle and inform when such a thing happens.

@robwasmann
Copy link
Member

It returns null? Also see the discussion I had in slack with Aman regarding using cvtcolor to convert the image to greyscale first if it's not already.

@AntonNiko
Copy link
Contributor

AntonNiko commented Dec 3, 2019

I tried some conversions that didn't work at all. Specifically detector.buoy_img.data returns a null pointer. Are the flags (e.g cv::IMREAD_GRAYSCALE) only an indication and have no effect on whether an image is read or not? I can work on those conversions then

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants