From b01610f6591a0199f58ed4e280626952e9f040f2 Mon Sep 17 00:00:00 2001 From: ShiCheng Lu Date: Sat, 8 Jan 2022 23:45:53 +0000 Subject: [PATCH 01/10] [SOFT-582] added Cppcheck to CI --- .github/workflows/main.yml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index f6cefad6d..f2221bb13 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -3,7 +3,7 @@ name: CI on: # Run on all pull requests and all pushes to master push: - branches: [ master ] + branches: [master] pull_request: # Allow running this workflow manually @@ -57,7 +57,7 @@ jobs: - uses: actions/setup-python@v2 with: - python-version: '3.9' + python-version: "3.9" - name: Install Python tooling run: | @@ -135,3 +135,8 @@ jobs: make test_all PLATFORM=x86 DEFINE="${DEFINES}" make pytest_all make build_all PLATFORM=x86 COMPILER=clang DEFINE="${DEFINES}" + + - name: Cppcheck MISRA-C Compilence + run: | + sudo apt-get install cppcheck + cppcheck --addon=misra.py projects From 038e5e9a84b6a501ebbe38373753e3659ec83ae6 Mon Sep 17 00:00:00 2001 From: ShiCheng Lu Date: Sun, 9 Jan 2022 03:54:45 +0000 Subject: [PATCH 02/10] [SOFT-582] seperate misra verification to ubuntu-21.04? --- .github/workflows/main.yml | 5 ----- .github/workflows/misra-ci.yml | 29 +++++++++++++++++++++++++++++ 2 files changed, 29 insertions(+), 5 deletions(-) create mode 100644 .github/workflows/misra-ci.yml diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index f2221bb13..ea967c962 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -135,8 +135,3 @@ jobs: make test_all PLATFORM=x86 DEFINE="${DEFINES}" make pytest_all make build_all PLATFORM=x86 COMPILER=clang DEFINE="${DEFINES}" - - - name: Cppcheck MISRA-C Compilence - run: | - sudo apt-get install cppcheck - cppcheck --addon=misra.py projects diff --git a/.github/workflows/misra-ci.yml b/.github/workflows/misra-ci.yml new file mode 100644 index 000000000..67d9b6410 --- /dev/null +++ b/.github/workflows/misra-ci.yml @@ -0,0 +1,29 @@ +name: CI + +on: + # Run on all pull requests and all pushes to master + push: + branches: [master] + pull_request: + + # Allow running this workflow manually + workflow_dispatch: + +jobs: + build: + runs-on: ubuntu-21.04 + timeout-minutes: 3 + steps: + - uses: actions/checkout@v2 + + - name: Setup directories + run: | + # create directory that will be on the PATH + mkdir -p ~/.local/bin + echo "${HOME}/.local/bin" >> $GITHUB_PATH + mkdir -p ~/source + + - name: Cppcheck MISRA-C Compilence + run: | + sudo apt-get install cppcheck + cppcheck --addon=misra.py projects --cppcheck-build-dir=build From 15d62f22a52d5f4f6455afa1b543b357086b655a Mon Sep 17 00:00:00 2001 From: ShiCheng Lu Date: Sun, 9 Jan 2022 03:56:22 +0000 Subject: [PATCH 03/10] [SOFT-582] changed name for Misra Ci --- .github/workflows/misra-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/misra-ci.yml b/.github/workflows/misra-ci.yml index 67d9b6410..0bdd81c46 100644 --- a/.github/workflows/misra-ci.yml +++ b/.github/workflows/misra-ci.yml @@ -1,4 +1,4 @@ -name: CI +name: Misra-CI on: # Run on all pull requests and all pushes to master From 5f1c3d0de9f3f60c724b53bfc8dd53a2755a1b34 Mon Sep 17 00:00:00 2001 From: ShiCheng Lu Date: Sun, 9 Jan 2022 18:16:57 +0000 Subject: [PATCH 04/10] [SOFT-582] use ubuntu 20.04 --- .github/workflows/main.yml | 10 ++++++++++ .github/workflows/misra-ci.yml | 29 ----------------------------- 2 files changed, 10 insertions(+), 29 deletions(-) delete mode 100644 .github/workflows/misra-ci.yml diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index ea967c962..7681960b4 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -135,3 +135,13 @@ jobs: make test_all PLATFORM=x86 DEFINE="${DEFINES}" make pytest_all make build_all PLATFORM=x86 COMPILER=clang DEFINE="${DEFINES}" + + misra-check: + runs-on: ubuntu-20.04 + timeout-minutes: 12 + steps: + - uses: actions/checkout@v2 + - name: Cppcheck MISRA-C Compilence + run: | + sudo apt-get install cppcheck + cppcheck --addon=misra.py --cppcheck-build-dir=build projects \ No newline at end of file diff --git a/.github/workflows/misra-ci.yml b/.github/workflows/misra-ci.yml deleted file mode 100644 index 0bdd81c46..000000000 --- a/.github/workflows/misra-ci.yml +++ /dev/null @@ -1,29 +0,0 @@ -name: Misra-CI - -on: - # Run on all pull requests and all pushes to master - push: - branches: [master] - pull_request: - - # Allow running this workflow manually - workflow_dispatch: - -jobs: - build: - runs-on: ubuntu-21.04 - timeout-minutes: 3 - steps: - - uses: actions/checkout@v2 - - - name: Setup directories - run: | - # create directory that will be on the PATH - mkdir -p ~/.local/bin - echo "${HOME}/.local/bin" >> $GITHUB_PATH - mkdir -p ~/source - - - name: Cppcheck MISRA-C Compilence - run: | - sudo apt-get install cppcheck - cppcheck --addon=misra.py projects --cppcheck-build-dir=build From cad2b85300ea6d5882c323116fbfff8044263abb Mon Sep 17 00:00:00 2001 From: ShiCheng Lu Date: Sun, 9 Jan 2022 18:30:53 +0000 Subject: [PATCH 05/10] [SOFT-582] added python setup step, needed? --- .github/workflows/main.yml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 7681960b4..76ee054e0 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -135,13 +135,17 @@ jobs: make test_all PLATFORM=x86 DEFINE="${DEFINES}" make pytest_all make build_all PLATFORM=x86 COMPILER=clang DEFINE="${DEFINES}" - + misra-check: runs-on: ubuntu-20.04 timeout-minutes: 12 steps: - uses: actions/checkout@v2 + - uses: actions/setup-python@v2 + with: + python-version: "3.9" + - name: Cppcheck MISRA-C Compilence run: | sudo apt-get install cppcheck - cppcheck --addon=misra.py --cppcheck-build-dir=build projects \ No newline at end of file + cppcheck --addon=misra.py --cppcheck-build-dir=cppcheckbuild projects From 98aa216080803202c47cf9db92e314f4063aa0c4 Mon Sep 17 00:00:00 2001 From: ShiCheng Lu Date: Sun, 9 Jan 2022 18:33:36 +0000 Subject: [PATCH 06/10] [SOFT-582] remove --cppcheck-build-dir --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 76ee054e0..9ba1c87dd 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -148,4 +148,4 @@ jobs: - name: Cppcheck MISRA-C Compilence run: | sudo apt-get install cppcheck - cppcheck --addon=misra.py --cppcheck-build-dir=cppcheckbuild projects + cppcheck --addon=misra.py projects From b8ffa483191b74c77f50734104f992dd9b1e7a9e Mon Sep 17 00:00:00 2001 From: ShiCheng Lu Date: Sun, 9 Jan 2022 18:51:21 +0000 Subject: [PATCH 07/10] [SOFT-582] check all c files in src --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 9ba1c87dd..948552c90 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -148,4 +148,4 @@ jobs: - name: Cppcheck MISRA-C Compilence run: | sudo apt-get install cppcheck - cppcheck --addon=misra.py projects + cppcheck --addon=misra.py . --file-filter=**/src/** From 4aaad9056c66f09d290bb446fabaf96fc89a691e Mon Sep 17 00:00:00 2001 From: ShiCheng Lu Date: Sun, 9 Jan 2022 19:01:05 +0000 Subject: [PATCH 08/10] [SOFT-582] cppcheck 1.90 doesnt have --file-filter apparently --- .github/workflows/main.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 948552c90..bb4f61a4c 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -136,9 +136,9 @@ jobs: make pytest_all make build_all PLATFORM=x86 COMPILER=clang DEFINE="${DEFINES}" - misra-check: + misra-cppcheck: runs-on: ubuntu-20.04 - timeout-minutes: 12 + timeout-minutes: 5 steps: - uses: actions/checkout@v2 - uses: actions/setup-python@v2 @@ -148,4 +148,5 @@ jobs: - name: Cppcheck MISRA-C Compilence run: | sudo apt-get install cppcheck - cppcheck --addon=misra.py . --file-filter=**/src/** + cppcheck + cppcheck --addon=misra.py . From 1ccd975caad438ec20405274d8372eb76bb1e3bd Mon Sep 17 00:00:00 2001 From: ShiCheng Lu Date: Sun, 9 Jan 2022 23:20:17 +0000 Subject: [PATCH 09/10] [SOFT-582] misra only checks **/src/** files, enable all checks --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index bb4f61a4c..a7147ee51 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -149,4 +149,4 @@ jobs: run: | sudo apt-get install cppcheck cppcheck - cppcheck --addon=misra.py . + find . -path **/src/** > cppcheck --enable=all --addon=misra.py --file-list=-, From cdcb397178fab1cdb997ff1588f5cd5babafc156 Mon Sep 17 00:00:00 2001 From: ShiCheng Lu Date: Sun, 9 Jan 2022 23:35:59 +0000 Subject: [PATCH 10/10] [SOFT-582] fixed workflow command err --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index a7147ee51..9b2725b90 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -149,4 +149,4 @@ jobs: run: | sudo apt-get install cppcheck cppcheck - find . -path **/src/** > cppcheck --enable=all --addon=misra.py --file-list=-, + find . -path **/src/** | cppcheck --enable=all --addon=misra.py --file-list=-