Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ReplaceableTable interface #878

Open
senderista opened this issue Feb 16, 2017 · 2 comments
Open

Add ReplaceableTable interface #878

senderista opened this issue Feb 16, 2017 · 2 comments
Assignees

Comments

@senderista
Copy link
Contributor

For classes like MutableTupleBuffer that allow random writes to cells, we have no interface comparable to ReadableTable or AppendableTable to represent the random write functionality. Just like we have ReplaceableColumn, we need ReplaceableTable for random write semantics.

@jingjingwang
Copy link
Contributor

Furthermore, I think some of our existing interfaces are designed with funny method names: WritableColumn has a bunch of append(), but AppendableTable has a bunch of put(). Readable is probably redundant since we don't really have Unreadable. And we can't cast Column<?> to be ReadableColumn.

@senderista
Copy link
Contributor Author

I think ReadableTable/ReadableColumn still makes sense for impls that only implement that interface. How else would they say "I'm a read-only table/column"?

I think maybe we should do away with the generic Column<> type altogether. I've literally never been able to parametrize it with a type and had the code compile--it's just Column<?> everywhere, which is pointless.

Agreed that put() doesn't sufficiently convey the idea of "append", and it would be better to just have methods called append() on AppendableTable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants