Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading saved queries involves too many clicks #479

Open
jnothman opened this issue Oct 29, 2021 · 2 comments
Open

Loading saved queries involves too many clicks #479

jnothman opened this issue Oct 29, 2021 · 2 comments

Comments

@jnothman
Copy link
Contributor

I would have expected that the Find Patients UI should make it easy to switch to a different query. Currently, however, it involves moving the mouse to several, quite small targets:

  • image
  • image
  • image

As long as "Run Query" is only available on the "Find Patients" page, it makes sense to have query loading accessible only from this page too, and to make the UI more accessible. Alternatively, run and load query should be straight on the nav bar.

I'd also suggest that clicking anywhere on the saved query row should open it, rather than needing to click "Open".

Also, clicking "Open" for the query currently being edited results in a no-op with no UI feedback. Perhaps "Open" should be renamed to "Current" as a simple fix. (But when I look at the code I am not certain how to make the queries.current.id state available to the SavedQueriesTable component, so perhaps a simpler fix would just be adding dispatch(setNoClickModalState({ message: "Already Loaded", state: NotificationStates.Complete })); before return here.

PS @ndobb, please lmk if I'm spamming you excessively or if this is helpful!

@ndobb
Copy link
Member

ndobb commented Oct 29, 2021

As the saying goes, PRs are welcome 😉.

@jnothman
Copy link
Contributor Author

jnothman commented Oct 31, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants