From 8a8c907b66af406b5a8ca05d92dcfb3da7d88b53 Mon Sep 17 00:00:00 2001 From: Seung-hee Bae Date: Mon, 11 Sep 2023 13:24:42 -0700 Subject: [PATCH] [oneMKL][spblas] add missing 'const' keyword for alpha, beta, and input array, and remove 'y' from input list in sparse::trsv() spec. (#498) --- .../oneMKL/source/domains/spblas/gemvdot.rst | 10 +++++----- .../elements/oneMKL/source/domains/spblas/symv.rst | 10 +++++----- .../elements/oneMKL/source/domains/spblas/trmv.rst | 10 +++++----- .../elements/oneMKL/source/domains/spblas/trsv.rst | 12 +----------- 4 files changed, 16 insertions(+), 26 deletions(-) diff --git a/source/elements/oneMKL/source/domains/spblas/gemvdot.rst b/source/elements/oneMKL/source/domains/spblas/gemvdot.rst index 349b69f4c..71d010829 100644 --- a/source/elements/oneMKL/source/domains/spblas/gemvdot.rst +++ b/source/elements/oneMKL/source/domains/spblas/gemvdot.rst @@ -45,10 +45,10 @@ gemvdot (Buffer version) void gemvdot (sycl::queue &queue, oneapi::mkl::transpose transpose_val, - fp alpha, + const fp alpha, oneapi::mkl::sparse::matrix_handle_t A_handle, sycl::buffer &x, - fp beta, + const fp beta, sycl::buffer &y, sycl::buffer &d); @@ -135,10 +135,10 @@ gemvdot (USM version) sycl::event gemvdot (sycl::queue &queue, oneapi::mkl::transpose transpose_val, - fp alpha, + const fp alpha, oneapi::mkl::sparse::matrix_handle_t A_handle, - fp *x, - fp beta, + const fp *x, + const fp beta, fp *y, fp *d, const std::vector &dependencies = {}); diff --git a/source/elements/oneMKL/source/domains/spblas/symv.rst b/source/elements/oneMKL/source/domains/spblas/symv.rst index bfb1bfc25..f51890e2d 100644 --- a/source/elements/oneMKL/source/domains/spblas/symv.rst +++ b/source/elements/oneMKL/source/domains/spblas/symv.rst @@ -39,10 +39,10 @@ symv (Buffer version) void symv (sycl::queue &queue, oneapi::mkl::uplo uplo_val, - fp alpha, + const fp alpha, oneapi::mkl::sparse::matrix_handle_t A_handle, sycl::buffer &x, - fp beta, + const fp beta, sycl::buffer &y); } @@ -125,10 +125,10 @@ symv (USM version) sycl::event symv (sycl::queue &queue, oneapi::mkl::uplo uplo_val, - fp alpha, + const fp alpha, oneapi::mkl::sparse::matrix_handle_t A_handle, - fp *x, - fp beta, + const fp *x, + const fp beta, fp *y, const std::vector &dependencies = {}); diff --git a/source/elements/oneMKL/source/domains/spblas/trmv.rst b/source/elements/oneMKL/source/domains/spblas/trmv.rst index 19ac8907c..b80e2e799 100644 --- a/source/elements/oneMKL/source/domains/spblas/trmv.rst +++ b/source/elements/oneMKL/source/domains/spblas/trmv.rst @@ -39,10 +39,10 @@ trmv (Buffer version) oneapi::mkl::uplo uplo_val oneapi::mkl::transpose transpose_val, oneapi::mkl::diag diag_val - fp alpha, + const fp alpha, oneapi::mkl::sparse::matrix_handle_t A_handle, sycl::buffer &x, - fp beta, + const fp beta, sycl::buffer &y); } @@ -138,10 +138,10 @@ trmv (USM version) oneapi::mkl::uplo uplo_val oneapi::mkl::transpose transpose_val, oneapi::mkl::diag diag_val - fp alpha, + const fp alpha, oneapi::mkl::sparse::matrix_handle_t A_handle, - fp *x, - fp beta, + const fp *x, + const fp beta, fp *y const std::vector &dependencies = {}); diff --git a/source/elements/oneMKL/source/domains/spblas/trsv.rst b/source/elements/oneMKL/source/domains/spblas/trsv.rst index 4634c953b..4e909e3dd 100644 --- a/source/elements/oneMKL/source/domains/spblas/trsv.rst +++ b/source/elements/oneMKL/source/domains/spblas/trsv.rst @@ -82,11 +82,6 @@ trsv (Buffer version) equal to the number of columns of matrix :math:`\text{op}(A)`. - y - SYCL memory object containing an array of size at least - equal to the number of rows of matrix :math:`\text{op}(A)`. - - .. container:: section @@ -129,7 +124,7 @@ trsv (USM version) oneapi::mkl::transpose transpose_val, oneapi::mkl::diag diag_val oneapi::mkl::sparse::matrix_handle_t A_handle, - fp *x, + const fp *x, fp *y const std::vector &dependencies = {}); @@ -171,11 +166,6 @@ trsv (USM version) equal to the number of columns of matrix :math:`\text{op}(A)`. - y - Device-accessible USM object containing an array of size at least - equal to the number of rows of matrix :math:`\text{op}(A)`. - - dependencies List of events that oneapi::mkl::sparse::trmv routine depends on. If omitted, defaults to no dependencies.